From: Ard Biesheuvel <firstname.lastname@example.org> To: Ard Biesheuvel <email@example.com>, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" <firstname.lastname@example.org>, Herbert Xu <email@example.com>, device-mapper development <firstname.lastname@example.org>, email@example.com, Gilad Ben-Yossef <firstname.lastname@example.org>, Milan Broz <email@example.com> Subject: Re: [dm-devel] [PATCH v10 2/7] fs: crypto: invoke crypto API for ESSIV handling Date: Tue, 13 Aug 2019 21:16:14 +0300 Message-ID: <CAKv+Gu8BFxyre0XDpE2To6yEvBP4E16abMZbR=r17TpQQko54Q@mail.gmail.com> (raw) In-Reply-To: <20190813180020.GA233786@gmail.com> On Tue, 13 Aug 2019 at 21:00, Eric Biggers <firstname.lastname@example.org> wrote: > > On Tue, Aug 13, 2019 at 08:09:41AM +0300, Ard Biesheuvel wrote: > > On Mon, 12 Aug 2019 at 22:47, Eric Biggers <email@example.com> wrote: > > > > > > On Mon, Aug 12, 2019 at 05:53:19PM +0300, Ard Biesheuvel wrote: > > > > Instead of open coding the calculations for ESSIV handling, use a > > > > ESSIV skcipher which does all of this under the hood. > > > > > > > > Signed-off-by: Ard Biesheuvel <firstname.lastname@example.org> > > > > > > This looks fine (except for one comment below), but this heavily conflicts with > > > the fscrypt patches planned for v5.4. So I suggest moving this to the end of > > > the series and having Herbert take only 1-6, and I'll apply this one to the > > > fscrypt tree later. > > > > > > > I think the same applies to dm-crypt: at least patch #7 cannot be > > applied until my eboiv patch is applied there as well, but [Milan > > should confirm] I'd expect them to prefer taking those patches via the > > dm tree anyway. > > > > Herbert, what would you prefer: > > - taking a pull request from a [signed] tag based on v4.3-rc1 that > > contains patches #1, #4, #5 and #6, allowing Eric and Milan/Mike to > > merge it as well, and apply the respective fscrypt and dm-crypt > > changes on top > > - just take patches #1, #4, #5 and #6 as usual, and let the fscrypt > > and dm-crypt changes be reposted to the respective lists during the > > next cycle > > > > FWIW I'd much prefer the second option, to minimize the number of special things > that Linus will have to consider or deal with. (There's also going to be a > conflict between the fscrypt and keyrings trees.) I'd be glad to take the > fscrypt patch for 5.5, if the essiv template is added in 5.4. > Works for me. I'll respin with the dm-crypt and fscrypt patches omitted (and the minor fixes you suggested applied).
next prev parent reply index Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-12 14:53 [PATCH v10 0/7] crypto: switch to crypto API for ESSIV generation Ard Biesheuvel 2019-08-12 14:53 ` [PATCH v10 1/7] crypto: essiv - create wrapper template " Ard Biesheuvel 2019-08-12 19:38 ` Eric Biggers 2019-08-13 5:17 ` Ard Biesheuvel 2019-08-12 14:53 ` [PATCH v10 2/7] fs: crypto: invoke crypto API for ESSIV handling Ard Biesheuvel 2019-08-12 19:47 ` Eric Biggers 2019-08-13 5:09 ` Ard Biesheuvel 2019-08-13 18:00 ` [dm-devel] " Eric Biggers 2019-08-13 18:16 ` Ard Biesheuvel [this message] 2019-08-12 14:53 ` [PATCH v10 3/7] md: dm-crypt: switch to ESSIV crypto API template Ard Biesheuvel 2019-08-12 14:53 ` [PATCH v10 4/7] crypto: essiv - add tests for essiv in cbc(aes)+sha256 mode Ard Biesheuvel 2019-08-12 14:53 ` [PATCH v10 5/7] crypto: arm64/aes-cts-cbc - factor out CBC en/decryption of a walk Ard Biesheuvel 2019-08-12 14:53 ` [PATCH v10 6/7] crypto: arm64/aes - implement accelerated ESSIV/CBC mode Ard Biesheuvel 2019-08-12 14:53 ` [PATCH v10 7/7] md: dm-crypt: omit parsing of the encapsulated cipher Ard Biesheuvel
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKv+Gu8BFxyre0XDpE2To6yEvBP4E16abMZbR=r17TpQQko54Q@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Crypto Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \ firstname.lastname@example.org public-inbox-index linux-crypto Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto AGPL code for this site: git clone https://public-inbox.org/public-inbox.git