From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>, Milan Broz <gmazyland@gmail.com>,
Pascal van Leeuwen <pvanleeuwen@verimatrix.com>,
Ondrej Mosnacek <omosnace@redhat.com>
Subject: Re: [PATCH v2] crypto: xts - add support for ciphertext stealing
Date: Fri, 16 Aug 2019 08:21:30 +0300 [thread overview]
Message-ID: <CAKv+Gu8ieCRH_R2EqwC-LMae5zaVrHMq_BuTDsN=5X1+u_CoWw@mail.gmail.com> (raw)
In-Reply-To: <20190816010233.GA653@sol.localdomain>
On Fri, 16 Aug 2019 at 04:02, Eric Biggers <ebiggers@kernel.org> wrote:
>
> On Thu, Aug 15, 2019 at 10:08:00PM +1000, Herbert Xu wrote:
> > On Fri, Aug 09, 2019 at 08:14:57PM +0300, Ard Biesheuvel wrote:
> > > Add support for the missing ciphertext stealing part of the XTS-AES
> > > specification, which permits inputs of any size >= the block size.
> > >
> > > Cc: Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
> > > Cc: Ondrej Mosnacek <omosnace@redhat.com>
> > > Tested-by: Milan Broz <gmazyland@gmail.com>
> > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > ---
> > > v2: fix scatterlist issue in async handling
> > > remove stale comment
> > >
> > > crypto/xts.c | 152 +++++++++++++++++---
> > > 1 file changed, 132 insertions(+), 20 deletions(-)
> >
> > Patch applied. Thanks.
> > --
>
> I'm confused why this was applied as-is, since there are no test vectors for
> this added yet. Nor were any other XTS implementations updated yet, so now
> users see inconsistent behavior, and all the XTS comparison fuzz tests fail.
> What is the plan for addressing these? I had assumed that as much as possible
> would be fixed up at once.
>
I have the ARM/arm64 changes mostly ready to go [0], but I haven't had
the opportunity to test them on actual hardware yet (nor will I until
the end of next month). This branch contains the test vectors as well,
which check out against these implementations and the generic one (and
Pascal's safexcel one), but obviously, we cannot merge those until all
drivers are fixed.
The fuzz tests failing transiently is not a huge deal, IMO, but we do
need a deadline when we apply the test vectors.
We'll need volunteers to fix the x86, powerpc and s390 code. My branch
adds some helpers that could be useful here, but it really needs the
attention of people who can understand the code and are able to test
it.
[0] https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=xts-cts
next prev parent reply other threads:[~2019-08-16 5:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 17:14 [PATCH v2] crypto: xts - add support for ciphertext stealing Ard Biesheuvel
2019-08-15 12:08 ` Herbert Xu
2019-08-16 1:02 ` Eric Biggers
2019-08-16 5:21 ` Ard Biesheuvel [this message]
2019-08-19 6:33 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu8ieCRH_R2EqwC-LMae5zaVrHMq_BuTDsN=5X1+u_CoWw@mail.gmail.com' \
--to=ard.biesheuvel@linaro.org \
--cc=gmazyland@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=pvanleeuwen@verimatrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).