linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Srujana Challa <schalla@marvell.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	Narayana Prasad Raju Athreya <pathreya@marvell.com>,
	Suheil Chandran <schandran@marvell.com>,
	"arno@natisbad.org" <arno@natisbad.org>,
	"bbrezillon@kernel.org" <bbrezillon@kernel.org>
Subject: Re: [EXT] Re: [PATCH v2 0/4] Add Support for Marvell OcteonTX Cryptographic
Date: Mon, 13 Apr 2020 15:47:43 +0200	[thread overview]
Message-ID: <CAKv+Gu9=bzFkDkFrkkmB-xM_Ff4ECR9Q5rPqmby6fijZsQmG0Q@mail.gmail.com> (raw)
In-Reply-To: <DM5PR18MB2311BB76C6A1F5C90B5D6A86A0DD0@DM5PR18MB2311.namprd18.prod.outlook.com>

On Mon, 13 Apr 2020 at 15:21, Srujana Challa <schalla@marvell.com> wrote:
>
> > Subject: RE: [EXT] Re: [PATCH v2 0/4] Add Support for Marvell OcteonTX
> > Cryptographic
> >
> > > On Fri, 20 Mar 2020 at 06:47, Srujana Challa <schalla@marvell.com> wrote:
> > > >
> > > > > On Fri, Mar 13, 2020 at 05:17:04PM +0530, Srujana Challa wrote:
> > > > > > The following series adds support for Marvell Cryptographic Accelerarion
> > > > > > Unit (CPT) on OcteonTX CN83XX SoC.
> > > > > >
> > > > > > Changes since v1:
> > > > > > * Replaced CRYPTO_BLKCIPHER with CRYPTO_SKCIPHER in Kconfig.
> > > > > >
> > > > > > Srujana Challa (4):
> > > > > >   drivers: crypto: create common Kconfig and Makefile for Marvell
> > > > > >   drivers: crypto: add support for OCTEON TX CPT engine
> > > > > >   drivers: crypto: add the Virtual Function driver for CPT
> > > > > >   crypto: marvell: enable OcteonTX cpt options for build
> > > > >
> > > > > There's no mention of testing.  Did you try
> > > > > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y?
> > > > >
> > > > Yes, the crypto self-tests are passed.
> > >
> > > *which* selftests are passed? Please confirm that they all passed with
> > > that kconfig option set
> > Apologies. I have overlooked the config option, I thought it was
> > CONFIG_CRYPTO_MANAGER_DISABLE_TESTS, all crypto self-tests are passed
> > with this option disabled. I have started verifying with
> > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y, I am getting few errors for
> > unsupported input lengths, will submit the patch with fixes.
>
> We confirmed that the failures are with unsupported lengths on our hardware, for some lengths we can resolve the issue by having validation checks in the driver but for some unsupported cases "testmgr.c" is excepting always success, I am still unsure how to fix/prevent these kind of failures. Can anyone please kindly help me out how to proceed on this issue.
> Thanks for your help.

You need to allocate fallbacks for the modes that your driver cannot
support. There are plenty of examples of that in the kernel tree.

      reply	other threads:[~2020-04-13 13:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13 11:47 Srujana Challa
2020-03-13 11:47 ` [PATCH v2 1/4] drivers: crypto: create common Kconfig and Makefile for Marvell Srujana Challa
2020-03-13 11:47 ` [PATCH v2 2/4] drivers: crypto: add support for OCTEON TX CPT engine Srujana Challa
2020-03-13 11:47 ` [PATCH v2 3/4] drivers: crypto: add the Virtual Function driver for CPT Srujana Challa
2020-03-13 11:47 ` [PATCH v2 4/4] crypto: marvell: enable OcteonTX cpt options for build Srujana Challa
2020-03-20  3:51 ` [PATCH v2 0/4] Add Support for Marvell OcteonTX Cryptographic Herbert Xu
2020-03-20  5:31 ` Eric Biggers
2020-03-20 10:47   ` [EXT] " Srujana Challa
2020-03-21 12:31     ` Ard Biesheuvel
2020-03-23  3:20       ` Srujana Challa
2020-04-13 13:21         ` Srujana Challa
2020-04-13 13:47           ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9=bzFkDkFrkkmB-xM_Ff4ECR9Q5rPqmby6fijZsQmG0Q@mail.gmail.com' \
    --to=ardb@kernel.org \
    --cc=arno@natisbad.org \
    --cc=bbrezillon@kernel.org \
    --cc=davem@davemloft.net \
    --cc=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=pathreya@marvell.com \
    --cc=schalla@marvell.com \
    --cc=schandran@marvell.com \
    --subject='Re: [EXT] Re: [PATCH v2 0/4] Add Support for Marvell OcteonTX Cryptographic' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).