From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F052C3F2D7 for ; Tue, 3 Mar 2020 22:20:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6321720870 for ; Tue, 3 Mar 2020 22:20:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JoEYFdqH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726809AbgCCWUS (ORCPT ); Tue, 3 Mar 2020 17:20:18 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:35205 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726766AbgCCWUQ (ORCPT ); Tue, 3 Mar 2020 17:20:16 -0500 Received: by mail-pf1-f193.google.com with SMTP id i19so2220831pfa.2 for ; Tue, 03 Mar 2020 14:20:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A0VgoCajNQtcqmr3sAxZ7zwAICIrcd2LUoNAPqwJhMc=; b=JoEYFdqH8VMWl/v3oH9VXqNGlxqWFgnorIuL0o80ZngwzS/ndHRTcASbqclRrUjUFS JqDXYy6BFgb8RRrFi0Wguy7MFjm1Rx9YwjkChVADEVVdGOzA/Nh6wAc8Fvp7yZSOaCZ4 cOzTqLmgjn4ShkaCTeB0wEWh3WU2S1mivlUnz8Qn+B2nvfX/AnGjrvd8CNWkq1bd8XQm p0PKu/SVvr1mTlYxgKG5QdG7UrmbLeScp3lDEyEy4N7EHsPCemUBKHbsMhp+PqtNrEMC iDc3Chr898nqiTtFwHk+hlM7QURM5bO50ptPMclx9dGGCYyAG7mOlQR5af5uVt1+dBGK B3qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A0VgoCajNQtcqmr3sAxZ7zwAICIrcd2LUoNAPqwJhMc=; b=ZZmv+9tNtgBXSgtoQ5enrWB9Zf5ib8hEXqBLnGDcz6GtPrw1o+4zdejjRweA8vS+s1 LfeIsFO3dv80sVu5GLGW6N73tjqi0/v1wDx7ONDNH/H3mX/JR0P15ti1kDDRwd8tJdhP c9AXk74HDzZ9RZtVVfP8tp7cMhaIUBXk0gNTYw2IeoXpEyd6JJoL99+iA1a5KjPWERKo iAOz3DxqX/emJbR4U3GkvOVTC5C+M+6AZi0CslLUqnolqXzYneF1m/Sub5n6//TADoXz uZ5OHisDD1z2ykH5KICaG8daQOgwykAG07tZHfgLvVLmPSsprSo0HhXmneWfWPovHBo3 UfLA== X-Gm-Message-State: ANhLgQ2D3PqDyJ/1O9d+yhyYsQAoOnZnVzk8+ylZWRsSGH8h+U8y0aME UMTKK0grSv8Blt5xLdxFVJ+jLFTqOa+WRDg1B38GTE77 X-Google-Smtp-Source: ADFU+vt4X4Q2+Uu+la/wP/hFUKrg/nR+9uZ1co62ESgEa0STG5Q0XI3VwZlAqZ1ci3kOGA0/3riqiLDrYgRWJ+NHPxM= X-Received: by 2002:a62:37c7:: with SMTP id e190mr6303201pfa.165.1583274014576; Tue, 03 Mar 2020 14:20:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Nick Desaulniers Date: Tue, 3 Mar 2020 14:20:03 -0800 Message-ID: Subject: Re: [PATCH] crypto: arm/ghash-ce - define fpu before fpu registers are referenced To: Stefan Agner Cc: Herbert Xu , "David S. Miller" , Russell King , Manoj Gupta , Jian Cai , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Linux ARM , LKML , clang-built-linux , Ard.Biesheuvel@arm.com Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Mar 1, 2020 at 3:37 PM Stefan Agner wrote: > > Building ARMv7 with Clang's integrated assembler leads to errors such > as: > arch/arm/crypto/ghash-ce-core.S:34:11: error: register name expected > t3l .req d16 > ^ > > Since no FPU has selected yet Clang considers d16 not a valid register. > Moving the FPU directive on-top allows Clang to parse the registers and > allows to successfully build this file with Clang's integrated assembler. Certainly a side effect of having a single pass assembler...This does fix what otherwise looks like a slew of errors for us, thanks for the patch. Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers > > Signed-off-by: Stefan Agner > --- > arch/arm/crypto/ghash-ce-core.S | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/crypto/ghash-ce-core.S b/arch/arm/crypto/ghash-ce-core.S > index 534c9647726d..9f51e3fa4526 100644 > --- a/arch/arm/crypto/ghash-ce-core.S > +++ b/arch/arm/crypto/ghash-ce-core.S > @@ -8,6 +8,9 @@ > #include > #include > > + .arch armv8-a > + .fpu crypto-neon-fp-armv8 > + > SHASH .req q0 > T1 .req q1 > XL .req q2 > @@ -88,8 +91,6 @@ > T3_H .req d17 > > .text > - .arch armv8-a > - .fpu crypto-neon-fp-armv8 > > .macro __pmull_p64, rd, rn, rm, b1, b2, b3, b4 > vmull.p64 \rd, \rn, \rm > -- > 2.25.1 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/c41cc67321d0b366e356440e6dbc9eceb1babfe4.1583105749.git.stefan%40agner.ch. -- Thanks, ~Nick Desaulniers