From: Andy Lutomirski <luto@amacapital.net>
To: Stephan Mueller <smueller@chronox.de>
Cc: Andy Lutomirski <luto@kernel.org>,
linux-crypto@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rusty Russell <rusty@rustcorp.com.au>, Jens Axboe <axboe@fb.com>,
Matt Mullins <mmullins@mmlx.us>
Subject: Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness()
Date: Mon, 17 Oct 2016 14:03:17 -0700 [thread overview]
Message-ID: <CALCETrXGRf3z8gGw6fjeMCzb=X_OF6y0Rbhh-wAGjUVad8eaMg@mail.gmail.com> (raw)
In-Reply-To: <1709183.xhj4cRUFK9@tauon.atsec.com>
On Mon, Oct 17, 2016 at 11:36 AM, Stephan Mueller <smueller@chronox.de> wrote:
> Am Montag, 17. Oktober 2016, 10:30:13 CEST schrieb Andy Lutomirski:
>
> Hi Andy,
>>
>> Sure, but shouldn't that be a separate patch covering the whole hw_crypto
>> core?
>
> I think that you are right -- there are many more cases where a memset(0) is
> warranted.
>
> Do you want to make this change or should I send a patch?
Can you do it? I have my work cut out for me making sure that all the
known regressions get stomped quickly...
next prev parent reply other threads:[~2016-10-17 21:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 17:06 [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness() Andy Lutomirski
2016-10-16 21:19 ` [PATCH " Matt Mullins
2016-10-17 17:17 ` [PATCH resend " Stephan Mueller
2016-10-17 17:30 ` Andy Lutomirski
2016-10-17 18:36 ` Stephan Mueller
2016-10-17 21:03 ` Andy Lutomirski [this message]
2016-10-17 21:14 ` Stephan Mueller
2016-10-19 3:50 ` Herbert Xu
2017-02-04 3:47 ` Yisheng Xie
2017-02-04 4:34 ` Matt Mullins
2017-02-04 10:32 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALCETrXGRf3z8gGw6fjeMCzb=X_OF6y0Rbhh-wAGjUVad8eaMg@mail.gmail.com' \
--to=luto@amacapital.net \
--cc=axboe@fb.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mmullins@mmlx.us \
--cc=mpm@selenic.com \
--cc=rusty@rustcorp.com.au \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).