From: Ard Biesheuvel <ardb@kernel.org>
To: Stefan Kanthak <stefan.kanthak@nexgo.de>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
tim.c.chen@linux.intel.com, Eric Biggers <ebiggers@kernel.org>
Subject: Re: [PATCH v2 1/2] crypto: s(h)aving 16 byte constant off arch/x86/crypto/sha1_ni_asm.S
Date: Mon, 8 Apr 2024 16:37:22 +0200 [thread overview]
Message-ID: <CAMj1kXGTrx_9igrewHOkfHAej4NdJBSKHtpCoQcif08EtF0pAA@mail.gmail.com> (raw)
In-Reply-To: <20240408141817.E22F8128369@smtp.subspace.kernel.org>
On Mon, 8 Apr 2024 at 16:18, Stefan Kanthak <stefan.kanthak@nexgo.de> wrote:
>
> Get rid of 16 byte constant, use shift instead of mask
>
This is missing a signoff
> --- -/arch/x86/crypto/sha1_ni_asm.S
> +++ +/arch/x86/crypto/sha1_ni_asm.S
> @@ -104,9 +104,9 @@
> add DATA_PTR, NUM_BLKS /* pointer to end of data */
>
> /* load initial hash values */
> - pinsrd $3, 1*16(DIGEST_PTR), E0
> + pinsrd $0, 1*16(DIGEST_PTR), E0
> movdqu 0*16(DIGEST_PTR), ABCD
> - pand UPPER_WORD_MASK(%rip), E0
> + pslldq $12, E0
> pshufd $0x1B, ABCD, ABCD
>
Wouldn't it be simpler and therefore better to simply zero register E0
before loading E into the top lane?
> movdqa PSHUFFLE_BYTE_FLIP_MASK(%rip), SHUF_MASK
> @@ -297,8 +297,3 @@
> .align 16
> PSHUFFLE_BYTE_FLIP_MASK:
> .octa 0x000102030405060708090a0b0c0d0e0f
> -
> -.section .rodata.cst16.UPPER_WORD_MASK, "aM", @progbits, 16
> -.align 16
> -UPPER_WORD_MASK:
> - .octa 0xFFFFFFFF000000000000000000000000
>
next parent reply other threads:[~2024-04-08 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240408141817.E22F8128369@smtp.subspace.kernel.org>
2024-04-08 14:37 ` Ard Biesheuvel [this message]
2024-04-08 14:08 [PATCH v2 1/2] crypto: s(h)aving 16 byte constant off arch/x86/crypto/sha1_ni_asm.S Stefan Kanthak
-- strict thread matches above, loose matches on Subject: below --
2024-04-08 14:08 Stefan Kanthak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXGTrx_9igrewHOkfHAej4NdJBSKHtpCoQcif08EtF0pAA@mail.gmail.com \
--to=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.kanthak@nexgo.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).