linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Ofir Drang <ofir.drang@arm.com>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] crypto: ccree - fix AEAD blocksize registration
Date: Wed, 29 Jan 2020 16:17:14 +0100	[thread overview]
Message-ID: <CAMuHMdVb_AGa7980fRXaxon=uDojZ1x5d6z-FCJAt5aMEGMcbw@mail.gmail.com> (raw)
In-Reply-To: <20200129143757.680-5-gilad@benyossef.com>

Hi Gilad,

On Wed, Jan 29, 2020 at 3:39 PM Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> Fix an error causing no block sizes to be reported during
> all AEAD registrations.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>

Thanks, this fixes:

    alg: aead: blocksize for authenc-hmac-sha1-cbc-aes-ccree (0)
doesn't match generic impl (16)
    alg: aead: blocksize for authenc-hmac-sha256-cbc-aes-ccree (0)
doesn't match generic impl (16)

which you may want to mention in the commit description, so
people who search for the error message will find the fix.

Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Note that even after applying this series, the kernel still crashes with

kernel BUG at kernel/dma/swiotlb.c:497!
....
Call trace:
 swiotlb_tbl_map_single+0x30c/0x380
 swiotlb_map+0xb0/0x300
 dma_direct_map_page+0xb8/0x140
 dma_direct_map_sg+0x78/0xe0
 cc_map_sg+0xa0/0xd0
 cc_aead_chain_data.constprop.25+0x17c/0x6a0
 cc_map_aead_request+0x61c/0x990
 cc_proc_aead+0x140/0xeb0
 cc_aead_decrypt+0x48/0x68
 crypto_aead_decrypt+0x30/0x48
 test_aead_vec_cfg+0x5a0/0x8d0

but you may be aware of that.

CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=n
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2020-01-29 15:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 14:37 [PATCH 0/4] crypto: ccree - fixes Gilad Ben-Yossef
2020-01-29 14:37 ` [PATCH 1/4] crypto: ccree - protect against empty or NULL scatterlists Gilad Ben-Yossef
2020-01-29 14:37 ` [PATCH 2/4] crypto: ccree - only try to map auth tag if needed Gilad Ben-Yossef
2020-01-29 14:37 ` [PATCH 3/4] crypto: ccree - fix some reported cipher block sizes Gilad Ben-Yossef
2020-01-29 14:57   ` Geert Uytterhoeven
2020-01-29 14:37 ` [PATCH 4/4] crypto: ccree - fix AEAD blocksize registration Gilad Ben-Yossef
2020-01-29 15:17   ` Geert Uytterhoeven [this message]
2020-01-30 11:33     ` Gilad Ben-Yossef
2020-01-30 13:19       ` Geert Uytterhoeven
2020-02-02 15:32         ` Gilad Ben-Yossef
2020-02-02 16:21           ` Gilad Ben-Yossef
2020-02-13  9:19 ` [PATCH 0/4] crypto: ccree - fixes Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdVb_AGa7980fRXaxon=uDojZ1x5d6z-FCJAt5aMEGMcbw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=davem@davemloft.net \
    --cc=gilad@benyossef.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ofir.drang@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).