From: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: David Gstir <david@sigma-star.at>,
linux-geode@lists.infradead.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, teheo@suse.de,
Richard Weinberger <richard@nod.at>
Subject: Re: Geode LX AES/RNG driver triggers warning
Date: Fri, 6 Jan 2017 15:10:19 +0530 [thread overview]
Message-ID: <CANc+2y7vh2U_Qrvwof8UZvJqVUL1hc3bQ5qgV-NJQnvQrmQn3Q@mail.gmail.com> (raw)
In-Reply-To: <20170103145203.780d3c58@lxorguk.ukuu.org.uk>
>> I narrowed it down to commit 6e9b5e76882c ("hwrng: geode - Migrate to managed API") which seems to introduce this. It looks to me like some issue between devres, the Geode hwrng and AES drivers which both use the same PCI device.
>
> It does
>
>> I'm no expert here, but I curious if this will cause any issues when using the hardware crypto drivers and also what's the best way to get rid of this?
>
> Probably to create an mfd device that turns the PCI device into two MFD
> devices and bind AES and hwrng one to each MFD device. Take a look in
> drivers/mfd. That would also fix the uglies in mod_init for the rng
> driver.
I am the author of that commit. Code before commit 6e9b5e76882c had
ioremap, wondering why there was no warning message before. Just want
to know if that commit uncovered existing issue or introduced a new
issue? As far as I understand the commit did not change the
functionality. Please feel free to correct if I have missed something.
Regards,
PrasannaKumar
next prev parent reply other threads:[~2017-01-06 9:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 23:58 Geode LX AES/RNG driver triggers warning David Gstir
2017-01-03 14:52 ` One Thousand Gnomes
2017-01-06 9:40 ` PrasannaKumar Muralidharan [this message]
2017-01-06 13:19 ` David Gstir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANc+2y7vh2U_Qrvwof8UZvJqVUL1hc3bQ5qgV-NJQnvQrmQn3Q@mail.gmail.com \
--to=prasannatsmkumar@gmail.com \
--cc=david@sigma-star.at \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=teheo@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).