From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FE58C433DF for ; Wed, 26 Aug 2020 12:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53E5E214F1 for ; Wed, 26 Aug 2020 12:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729911AbgHZM6Q (ORCPT ); Wed, 26 Aug 2020 08:58:16 -0400 Received: from mail-il1-f193.google.com ([209.85.166.193]:41461 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730043AbgHZM6P (ORCPT ); Wed, 26 Aug 2020 08:58:15 -0400 Received: by mail-il1-f193.google.com with SMTP id q14so1634457ilj.8; Wed, 26 Aug 2020 05:58:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/KmmQfwHULnlIqQl6u1SzgqJsX9j6BWCR4avQA0PcIY=; b=mCjr4RfYZrTnvwg1wtiV5Dqk3bZjs2Hw/15jyQl0zV8Z6B1630SDVELnfbsd3djWyH 83Nhf8sM4AsZCKOt9AY3IBRS5o9rqUe89Fd0jKX/+D3bqwHNEDycyL4wAsboRttrNY1N k3HYZNqD665QGzT683pR3iMUdxbShM6QFval8a9k5du5W7o2N7PtqAOBqYaWL9VAWrIM oBEjnucZgn8CsYUPvIcQcxgV5/RBKDbm21lBZodxpv3N+1zf1CoOOmxowHFE7ZcDTMJ5 scREc10dxjkoptt3dv1XIj6FnKoo01GGqNjuhBrvwYj7N+3F2ea/xfbC5wDgeGsN3UPw fAXA== X-Gm-Message-State: AOAM530K81PPqPJOoLRIu32/8T6TBtqm7vSoNR+QGdUaRozzSzGjdNAc rM7YuCp8AAT29Pb/LES2Na7ZUofrsNi1lL5c X-Google-Smtp-Source: ABdhPJzSa39y60rj1/s3hqpO8RiVivbI9Dctz/s6tHNYXlw7c7JSCbGkeubk29JzRI2E0ZbuWggZDw== X-Received: by 2002:a92:6b04:: with SMTP id g4mr13592283ilc.192.1598446694641; Wed, 26 Aug 2020 05:58:14 -0700 (PDT) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com. [209.85.166.179]) by smtp.gmail.com with ESMTPSA id o1sm1310062ils.1.2020.08.26.05.58.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2020 05:58:14 -0700 (PDT) Received: by mail-il1-f179.google.com with SMTP id f75so1649009ilh.3; Wed, 26 Aug 2020 05:58:13 -0700 (PDT) X-Received: by 2002:a92:ca8d:: with SMTP id t13mr13377470ilo.302.1598446693534; Wed, 26 Aug 2020 05:58:13 -0700 (PDT) MIME-Version: 1.0 References: <20200826055150.2753.90553@ml01.vlan13.01.org> <20200826114952.GA2375@gondor.apana.org.au> <20200826120832.GA2996@gondor.apana.org.au> In-Reply-To: <20200826120832.GA2996@gondor.apana.org.au> From: Andrew Zaborowski Date: Wed, 26 Aug 2020 14:58:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Issue with iwd + Linux 5.8.3 + WPA Enterprise To: Herbert Xu Cc: Ard Biesheuvel , Paul Menzel , Caleb Jorden , Sasha Levin , iwd@lists.01.org, "# 3.4.x" , Greg KH , LKML , "David S. Miller" , Linux Crypto Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, 26 Aug 2020 at 14:10, Herbert Xu wrote: > On Wed, Aug 26, 2020 at 01:59:53PM +0200, Ard Biesheuvel wrote: > > On Wed, 26 Aug 2020 at 13:50, Herbert Xu wrote: > > > > > > On Wed, Aug 26, 2020 at 12:40:14PM +0200, Ard Biesheuvel wrote: > > > > > > > > It would be helpful if someone could explain for the non-mac80211 > > > > enlightened readers how iwd's EAP-PEAPv0 + MSCHAPv2 support relies on > > > > the algif_aead socket interface, and which AEAD algorithms it uses. I > > > > assume this is part of libell? > > > > > > I see the problem. libell/ell/checksum.c doesn't clear the MSG_MORE > > > flag before doing the recv(2). > > > > But that code uses a hash not an aead, afaict. > > Good point. In that case can we please get a strace with a -s > option that's big enough to capture the crypto data? Running iwd's and ell's unit tests I can see that at least the following algorithms give EINVAL errors: ecb(aes) cbc(aes) ctr(aes) The first one fails in recv() and only for some input lengths. The latter two fail in send(). The relevant ell code starts at https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/ell/cipher.c#n271 The tests didn't get to the point where aead is used. Best regards