From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3660C33CB3 for ; Thu, 30 Jan 2020 11:33:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8256206D3 for ; Thu, 30 Jan 2020 11:33:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=benyossef-com.20150623.gappssmtp.com header.i=@benyossef-com.20150623.gappssmtp.com header.b="m1CNO0r9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727210AbgA3LdZ (ORCPT ); Thu, 30 Jan 2020 06:33:25 -0500 Received: from mail-vs1-f68.google.com ([209.85.217.68]:35092 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727164AbgA3LdZ (ORCPT ); Thu, 30 Jan 2020 06:33:25 -0500 Received: by mail-vs1-f68.google.com with SMTP id x123so1851292vsc.2 for ; Thu, 30 Jan 2020 03:33:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benyossef-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sachUFQOePxVrLNclWklF0gCfdMb5uCt5/iIiiOjQ6k=; b=m1CNO0r97qGHq1nZLkvorYbHCl6n3yiSngEKvS8X15JFdYJBqxFNmht5iX0MecxIOP 4O6kew+CVKxdg87E9RakdF7ZlSNNkO0O1OoKOxGWLojbtznM9xvA2OxGq3aXJsNzwrDm 1IYGvi7B54p545j97fkkv04Amo4Hq9RpS2+z+lyNUoF4an8lBtJjS/G4cTjJbQkmX2bc h7nNqV39Z5K0/ImATsG6f52N36W+LLu5YT3ohyEgwAbYlPcglHJRq56hKNjEu74wW88j EMpyr9P8VkVZQJk6fiw8x7mSXBySOcs1tFJc2COZrCNRnWB+2VDvGZapfDNs+Ksg28iw zZYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sachUFQOePxVrLNclWklF0gCfdMb5uCt5/iIiiOjQ6k=; b=jcLfpgR64Sa2P3r3gt919L9Lm3fQrllus0YbARwYlOuQ0wWF30/YsZ78Zx7pvk8I4D HEQ5SzF1BJ4y770q3IxgwwK0P938HkLCPhEkzVt2EjNwlM6LTn4ZcESHiP7ptVU0voaJ yvpIGa8hS0qQnvfCSB5P39q1B75VlyJJqpx7l5c7yWEqEmTU59sYdzF1TP/hM1mV0P7y G5M8Dwa/oT5k/LOXhWro/RoRckTLHM+Og0WX7E2dIfS4nrzDro18+2LjUB4/uBI6qFbu yykMMcRvLHgsFRv2kfQTizlgm4VNxALaIYNEnPQAz6emkstifWPHIrm8rzLcDlhBDLx1 NSNQ== X-Gm-Message-State: APjAAAUBJZPSG0QbaYtlzH2KyG3AiafH0UnR1JtrugCWnCgCAlmQ4KTI mymYF4OPKym0PTblqr4Pa+/2d0ckwgcQ3YtIdrsXOQ== X-Google-Smtp-Source: APXvYqwRQewNB6JLSsvrZO8yrxek6cyYeBRvAzzDHbobVzvuHWcoLLJAsh/yeAgxIeeiqq8PqEYjkLQByU/8fRohxEg= X-Received: by 2002:a67:fb14:: with SMTP id d20mr2749866vsr.136.1580384004008; Thu, 30 Jan 2020 03:33:24 -0800 (PST) MIME-Version: 1.0 References: <20200129143757.680-1-gilad@benyossef.com> <20200129143757.680-5-gilad@benyossef.com> In-Reply-To: From: Gilad Ben-Yossef Date: Thu, 30 Jan 2020 13:33:11 +0200 Message-ID: Subject: Re: [PATCH 4/4] crypto: ccree - fix AEAD blocksize registration To: Geert Uytterhoeven Cc: Herbert Xu , "David S. Miller" , Ofir Drang , Linux Crypto Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jan 29, 2020 at 5:17 PM Geert Uytterhoeven wrote: > > Hi Gilad, > > On Wed, Jan 29, 2020 at 3:39 PM Gilad Ben-Yossef wrote: > > Fix an error causing no block sizes to be reported during > > all AEAD registrations. > > > > Signed-off-by: Gilad Ben-Yossef > > Thanks, this fixes: > > alg: aead: blocksize for authenc-hmac-sha1-cbc-aes-ccree (0) > doesn't match generic impl (16) > alg: aead: blocksize for authenc-hmac-sha256-cbc-aes-ccree (0) > doesn't match generic impl (16) > > which you may want to mention in the commit description, so > people who search for the error message will find the fix. > > Tested-by: Geert Uytterhoeven > > Note that even after applying this series, the kernel still crashes with > > kernel BUG at kernel/dma/swiotlb.c:497! > .... > Call trace: > swiotlb_tbl_map_single+0x30c/0x380 > swiotlb_map+0xb0/0x300 > dma_direct_map_page+0xb8/0x140 > dma_direct_map_sg+0x78/0xe0 > cc_map_sg+0xa0/0xd0 > cc_aead_chain_data.constprop.25+0x17c/0x6a0 > cc_map_aead_request+0x61c/0x990 > cc_proc_aead+0x140/0xeb0 > cc_aead_decrypt+0x48/0x68 > crypto_aead_decrypt+0x30/0x48 > test_aead_vec_cfg+0x5a0/0x8d0 > > but you may be aware of that. > > CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=n > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y OK, this is a new one yet - we are now crashing in out-of-place decryption. And again, I am not seeing this in the different test board, even with DMA debug turned on. Can you help me out and print the cryptlen and assoclen (I'm guessing both are zero), authlen and which AEAD/mode this is? Thanks alot, Gilad