From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D4CC35249 for ; Sun, 2 Feb 2020 16:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E76852067C for ; Sun, 2 Feb 2020 16:21:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=benyossef-com.20150623.gappssmtp.com header.i=@benyossef-com.20150623.gappssmtp.com header.b="hBAs0OVt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbgBBQVp (ORCPT ); Sun, 2 Feb 2020 11:21:45 -0500 Received: from mail-vs1-f68.google.com ([209.85.217.68]:35032 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726912AbgBBQVo (ORCPT ); Sun, 2 Feb 2020 11:21:44 -0500 Received: by mail-vs1-f68.google.com with SMTP id x123so7432043vsc.2 for ; Sun, 02 Feb 2020 08:21:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benyossef-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=z4vFhFVKG0YBD0XPtA9xGNCv/BDXDAEGk9Fr40UlAwQ=; b=hBAs0OVt/5C+i6kyW+CHbqpB9gOyPcztzdOGnLqZd5PmvPRtm4vj5Yq14SKZEQH+SY 7f889N/sdhK7bafCMvpU1y0a0FO8QTk/CF8hVEEynBHPtdRJ8YxBuRvsgDC5E4bNPBBB 7YHLBYy0Z7P5T2vrz32I0pXDit/bZvnL81pcUQQ9BfR8Sq+QCwTME+Hd298JAY0sQOVo pjZnsd8v3sulZFUUy6fQG0YkTsF4Mrp9vxPQH6cTDUZOInl4YSHDJ059G92JX9+KLByv Yy2EzaiSbRMTfMIhb+F0ZO5/7+UI/jTPldHzlIhh1+AJuBg+JRj936mzOkLRPv6qsOH3 sBkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=z4vFhFVKG0YBD0XPtA9xGNCv/BDXDAEGk9Fr40UlAwQ=; b=JtfE8turQVNpmLmp20sEPOElAxgIBhq19yEAJKItg21D/zOD2Sc17yd2xs53OT/s/z gEMDcix5ahhzpbV1HldFBTeBGSfHBOjAr1bAE/BIzvETj8e8NUEbkoU0wiLgo4acI1Sc D1RaXOMAv1Zx5yAnaL9FZ71QYEc+3jcKZwyXI4cvSgbQgi2OXL9xbCQUqCu95pZyiITp 9CFFsjMzmPRKj3LCQJI/UdB7PJp4BvvysCwFZsz7ga3JLLnLXp9g4mgNXQZ2hjEghtqI Au41/WlDPP31E0XUaVqxfazkfTRriaT6tp8lXdQ0C8G/w8Dvwl5Cy/FtGGzp9ORFy5Ni c47w== X-Gm-Message-State: APjAAAUtOXEJQmR1BKOdgNwUsvnpWauY+BWapMmRlrf4Yyva4FaXVZvP h+oX9ivTG7+/BgeOXBihW9P9d3zUECJc7dDlv29jgA== X-Google-Smtp-Source: APXvYqx3XNZF2JXa9iGlKzd5VrwmWrEsb5RS4U0pCifaad4M/KM1FTXTr9XHmHL7Tsoi05WpBaJMhegB5m28Ryh/ewg= X-Received: by 2002:a67:fb14:: with SMTP id d20mr12085906vsr.136.1580660503807; Sun, 02 Feb 2020 08:21:43 -0800 (PST) MIME-Version: 1.0 References: <20200129143757.680-1-gilad@benyossef.com> <20200129143757.680-5-gilad@benyossef.com> In-Reply-To: From: Gilad Ben-Yossef Date: Sun, 2 Feb 2020 18:21:31 +0200 Message-ID: Subject: Re: [PATCH 4/4] crypto: ccree - fix AEAD blocksize registration To: Geert Uytterhoeven Cc: Herbert Xu , "David S. Miller" , Ofir Drang , Linux Crypto Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Feb 2, 2020 at 5:32 PM Gilad Ben-Yossef wrote= : > > On Thu, Jan 30, 2020 at 3:19 PM Geert Uytterhoeven = wrote: > > > > Hi Gilad, > > > > On Thu, Jan 30, 2020 at 12:33 PM Gilad Ben-Yossef = wrote: > > > On Wed, Jan 29, 2020 at 5:17 PM Geert Uytterhoeven wrote: > > > > On Wed, Jan 29, 2020 at 3:39 PM Gilad Ben-Yossef wrote: > > > > > Fix an error causing no block sizes to be reported during > > > > > all AEAD registrations. > > > > > > > > > > Signed-off-by: Gilad Ben-Yossef > > > > > > > > Thanks, this fixes: > > > > > > > > alg: aead: blocksize for authenc-hmac-sha1-cbc-aes-ccree (0) > > > > doesn't match generic impl (16) > > > > alg: aead: blocksize for authenc-hmac-sha256-cbc-aes-ccree (0) > > > > doesn't match generic impl (16) > > > > > > > > which you may want to mention in the commit description, so > > > > people who search for the error message will find the fix. > > > > > > > > Tested-by: Geert Uytterhoeven > > > > > > > > Note that even after applying this series, the kernel still crashes= with > > > > > > > > kernel BUG at kernel/dma/swiotlb.c:497! > > > > .... > > Thank you! > > I've managed to reproduce this here. > Looking into it now... OK, found it (I think!). Patch sent. I don't understand why this and the previous bugs is not causing problems with other configs (e.g. 32 bit ) but now I have an environment that triggers them I will add it to the usual tests cycle. Thanks again! Gilad --=20 Gilad Ben-Yossef Chief Coffee Drinker values of =CE=B2 will give rise to dom!