From: Gilad Ben-Yossef <gilad@benyossef.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: "Ondrej Mosnáček" <omosnacek+linux-crypto@gmail.com>,
dm-devel@redhat.com, "Alasdair Kergon" <agk@redhat.com>,
"Mike Snitzer" <snitzer@redhat.com>,
linux-crypto@vger.kernel.org, gilad.benyossef@arm.com,
Ofir <ofir.drang@arm.com>
Subject: Re: [PATCH] dm: switch dm-verity to async hash crypto API
Date: Mon, 6 Feb 2017 16:02:17 +0200 [thread overview]
Message-ID: <CAOtvUMemy1j6rB0rs43P7LLywMHvrmUUw4R6Pc4OfQd4F37OVA@mail.gmail.com> (raw)
In-Reply-To: <20170130002844.GB5253@zzz>
Hi Eric,
On Mon, Jan 30, 2017 at 2:28 AM, Eric Biggers <ebiggers3@gmail.com> wrote:
...
> As for the patch, I haven't looked at it in detail, but I agree that if
> dm-verity is indeed operating on sufficiently large buffers in physically
> contiguous memory, then the ahash API would be better than the shash API. Note,
> that it also could be useful look into supporting having multiple async requests
> issued and pending at the same time, similar to what dm-crypt does.
Thank you for the feedback Eric.
I just sent out a v2 with fixes based on Ondrej feedback.
Supporting multiple outstanding async requests is a great idea. I will
look into supporting it.
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
prev parent reply other threads:[~2017-02-06 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 14:38 [PATCH] dm: switch dm-verity to async hash crypto API Gilad Ben-Yossef
2017-01-26 11:34 ` Ondrej Mosnáček
2017-01-29 7:39 ` Gilad Ben-Yossef
2017-01-30 0:28 ` Eric Biggers
2017-02-06 14:02 ` Gilad Ben-Yossef [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOtvUMemy1j6rB0rs43P7LLywMHvrmUUw4R6Pc4OfQd4F37OVA@mail.gmail.com \
--to=gilad@benyossef.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ebiggers3@gmail.com \
--cc=gilad.benyossef@arm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=ofir.drang@arm.com \
--cc=omosnacek+linux-crypto@gmail.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).