From: Hadar Gat <Hadar.Gat@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Mark Rutland <Mark.Rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tomer Maimon <tmaimon77@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Zaibo Xu <xuzaibo@huawei.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Gilad Ben-Yossef <gilad@benyossef.com>,
Ofir Drang <Ofir.Drang@arm.com>, nd <nd@arm.com>
Subject: RE: [PATCH v6 1/3] dt-bindings: add device tree binding for Arm CryptoCell trng engine
Date: Thu, 26 Mar 2020 21:04:46 +0000 [thread overview]
Message-ID: <DB6PR0802MB25334E308B8D4B10D2562460E9CF0@DB6PR0802MB2533.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20200326194104.GA4118@bogus>
Hi Rob,
>
> On Wed, Mar 25, 2020 at 07:41:09AM +0200, Hadar Gat wrote:
> > The Arm CryptoCell is a hardware security engine. This patch adds DT
> > bindings for its TRNG (True Random Number Generator) engine.
> >
> > Signed-off-by: Hadar Gat <hadar.gat@arm.com>
> > ---
> > .../devicetree/bindings/rng/arm-cctrng.yaml | 55
> ++++++++++++++++++++++
> > 1 file changed, 55 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> > b/Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> > new file mode 100644
> > index 0000000..7f70e4b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> > @@ -0,0 +1,55 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rng/arm-cctrng.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Arm TrustZone CryptoCell TRNG engine
> > +
> > +maintainers:
> > + - Hadar Gat <hadar.gat@arm.com>
> > +
> > +description: |+
> > + Arm TrustZone CryptoCell TRNG (True Random Number Generator)
> engine.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - arm,cryptocell-713-trng
> > + - arm,cryptocell-703-trng
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + arm,rosc-ratio:
> > + description:
> > + Arm TrustZone CryptoCell TRNG engine has 4 ring oscillators.
> > + Sampling ratio values for these 4 ring oscillators. (from calibration)
> > + allOf:
> > + - $ref: /schemas/types.yaml#/definitions/uint32-array
> > + - items:
> > + minItems: 4
> > + maxItems: 4
>
> Aren't there some constraints on the values?
>
> If not, then just this is enough:
>
> - maxItems: 4
>
The constraint is just on the array size and not on the values.
The array is of 4 elements for the CryptoCell 4 ring oscillators.
Isn't 'minitems:' is about the array min size? Isn't it the way to block less than 4 items? This is what I want to do.
I'm a bit confused if it is required or not..
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - interrupts
> > + - reg
> > + - arm,rosc-ratio
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + arm_cctrng: rng@60000000 {
> > + compatible = "arm,cryptocell-713-trng";
> > + interrupts = <0 29 4>;
> > + reg = <0x60000000 0x10000>;
> > + arm,rosc-ratio = <5000 1000 500 0>;
> > + };
> > --
> > 2.7.4
> >
Thanks,
Hadar
next prev parent reply other threads:[~2020-03-26 21:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 5:41 [PATCH v6 0/3] hw_random: introduce Arm CryptoCell TRNG driver Hadar Gat
2020-03-25 5:41 ` [PATCH v6 1/3] dt-bindings: add device tree binding for Arm CryptoCell trng engine Hadar Gat
2020-03-26 19:41 ` Rob Herring
2020-03-26 21:04 ` Hadar Gat [this message]
2020-03-27 3:04 ` Rob Herring
2020-03-25 5:41 ` [PATCH v6 2/3] hw_random: cctrng: introduce Arm CryptoCell driver Hadar Gat
2020-03-25 5:41 ` [PATCH v6 3/3] MAINTAINERS: add HG as cctrng maintainer Hadar Gat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0802MB25334E308B8D4B10D2562460E9CF0@DB6PR0802MB2533.eurprd08.prod.outlook.com \
--to=hadar.gat@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Mark.Rutland@arm.com \
--cc=Ofir.Drang@arm.com \
--cc=alexander.sverdlin@nokia.com \
--cc=arnd@arndb.de \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mpm@selenic.com \
--cc=nd@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmaimon77@gmail.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).