[PATCH -next] hwrng: cctrng - Make some symbols static

[PATCH -next] hwrng: cctrng - Make some symbols static

[Zou Wei]

Fix the following sparse warnings:

drivers/char/hw_random/cctrng.c:316:6: warning: symbol
'cc_trng_compwork_handler' was not declared. Should it be static?
drivers/char/hw_random/cctrng.c:451:6: warning: symbol
'cc_trng_startwork_handler' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/char/hw_random/cctrng.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/hw_random/cctrng.c b/drivers/char/hw_random/cctrng.c
index e82716c..3ff37a6 100644
--- a/drivers/char/hw_random/cctrng.c
+++ b/drivers/char/hw_random/cctrng.c
@@ -313,7 +313,7 @@ static void cc_trng_hw_trigger(struct cctrng_drvdata *drvdata)
 	cc_trng_enable_rnd_source(drvdata);
 }
 
-void cc_trng_compwork_handler(struct work_struct *w)
+static void cc_trng_compwork_handler(struct work_struct *w)
 {
 	u32 isr = 0;
 	u32 ehr_valid = 0;
@@ -448,7 +448,7 @@ static irqreturn_t cc_isr(int irq, void *dev_id)
 	return IRQ_HANDLED;
 }
 
-void cc_trng_startwork_handler(struct work_struct *w)
+static void cc_trng_startwork_handler(struct work_struct *w)
 {
 	struct cctrng_drvdata *drvdata =
 			container_of(w, struct cctrng_drvdata, startwork);
-- 
2.6.2

RE: [PATCH -next] hwrng: cctrng - Make some symbols static

[Hadar Gat]

> -----Original Message-----
> From: Zou Wei <zou_wei@huawei.com>
> Sent: Thursday, 23 April 2020 15:21
> 
> Fix the following sparse warnings:
> 
> drivers/char/hw_random/cctrng.c:316:6: warning: symbol
> 'cc_trng_compwork_handler' was not declared. Should it be static?
> drivers/char/hw_random/cctrng.c:451:6: warning: symbol
> 'cc_trng_startwork_handler' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/char/hw_random/cctrng.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/hw_random/cctrng.c
> b/drivers/char/hw_random/cctrng.c index e82716c..3ff37a6 100644
> --- a/drivers/char/hw_random/cctrng.c
> +++ b/drivers/char/hw_random/cctrng.c
> @@ -313,7 +313,7 @@ static void cc_trng_hw_trigger(struct cctrng_drvdata
> *drvdata)
>  	cc_trng_enable_rnd_source(drvdata);
>  }
> 
> -void cc_trng_compwork_handler(struct work_struct *w)
> +static void cc_trng_compwork_handler(struct work_struct *w)
>  {
>  	u32 isr = 0;
>  	u32 ehr_valid = 0;
> @@ -448,7 +448,7 @@ static irqreturn_t cc_isr(int irq, void *dev_id)
>  	return IRQ_HANDLED;
>  }
> 
> -void cc_trng_startwork_handler(struct work_struct *w)
> +static void cc_trng_startwork_handler(struct work_struct *w)
>  {
>  	struct cctrng_drvdata *drvdata =
>  			container_of(w, struct cctrng_drvdata, startwork);
> --
> 2.6.2

Acked-by: Hadar Gat <hadar.gat@arm.com>

Re: [PATCH -next] hwrng: cctrng - Make some symbols static

[Herbert Xu]

Zou Wei <zou_wei@huawei.com> wrote:
> Fix the following sparse warnings:
> 
> drivers/char/hw_random/cctrng.c:316:6: warning: symbol
> 'cc_trng_compwork_handler' was not declared. Should it be static?
> drivers/char/hw_random/cctrng.c:451:6: warning: symbol
> 'cc_trng_startwork_handler' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/char/hw_random/cctrng.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt