From: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
To: Antoine Tenart <antoine.tenart@bootlin.com>
Cc: Pascal van Leeuwen <pascalvanl@gmail.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [PATCH 2/2] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD
Date: Wed, 11 Sep 2019 15:49:48 +0000 [thread overview]
Message-ID: <MN2PR20MB29736EBD0F025DFDB5CF53D9CAB10@MN2PR20MB2973.namprd20.prod.outlook.com> (raw)
In-Reply-To: <20190911154514.GE5492@kwain>
> -----Original Message-----
> From: Antoine Tenart <antoine.tenart@bootlin.com>
> Sent: Wednesday, September 11, 2019 5:45 PM
> To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
> Cc: Antoine Tenart <antoine.tenart@bootlin.com>; Pascal van Leeuwen
> <pascalvanl@gmail.com>; linux-crypto@vger.kernel.org; herbert@gondor.apana.org.au;
> davem@davemloft.net
> Subject: Re: [PATCH 2/2] crypto: inside-secure - Add support for the Chacha20-Poly1305
> AEAD
>
> On Wed, Sep 11, 2019 at 03:37:25PM +0000, Pascal Van Leeuwen wrote:
> > > On Tue, Sep 10, 2019 at 04:38:13PM +0200, Pascal van Leeuwen wrote:
> > > > @@ -43,8 +44,8 @@ struct safexcel_cipher_ctx {
> > > >
> > > > u32 mode;
> > > > enum safexcel_cipher_alg alg;
> > > > - bool aead;
> > > > - int xcm; /* 0=authenc, 1=GCM, 2 reserved for CCM */
> > > > + char aead; /* !=0=AEAD, 2=IPSec ESP AEAD */
> > > > + char xcm; /* 0=authenc, 1=GCM, 2 reserved for CCM */
> > >
> > > You could use an u8 instead. It also seems the aead comment has an
> > > issue, I'll let you check that.
> > >
> > I don't see what's wrong with the comment though?
> > Anything unequal to 0 is AEAD, with value 2 being the ESP variant.
>
> OK, that wasn't clear to me when I first read it. Maybe you could say
> that 1: AEAD, 2: IPsec ESP AEAD; and then of course the check of this
> value being > 0 would mean it's one of the two.
>
OK, agree that that's clearer so I will change it to that.
> Thanks!
> Antoine
>
> --
> Antoine Ténart, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com
prev parent reply other threads:[~2019-09-11 15:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 14:38 [PATCH 0/2] crypto: inside-secure: Add support for the Chacha20 skcipher and the Chacha20-Poly1305 AEAD suites Pascal van Leeuwen
2019-09-10 14:38 ` [PATCH 1/2] crypto: inside-secure - Added support for the CHACHA20 skcipher Pascal van Leeuwen
2019-09-10 17:32 ` Antoine Tenart
2019-09-10 18:58 ` Pascal Van Leeuwen
2019-09-11 15:21 ` Antoine Tenart
2019-09-11 15:32 ` Pascal Van Leeuwen
2019-09-10 14:38 ` [PATCH 2/2] crypto: inside-secure - Add support for the Chacha20-Poly1305 AEAD Pascal van Leeuwen
2019-09-11 15:29 ` Antoine Tenart
2019-09-11 15:37 ` Pascal Van Leeuwen
2019-09-11 15:45 ` Antoine Tenart
2019-09-11 15:49 ` Pascal Van Leeuwen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR20MB29736EBD0F025DFDB5CF53D9CAB10@MN2PR20MB2973.namprd20.prod.outlook.com \
--to=pvanleeuwen@verimatrix.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=pascalvanl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).