RE: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-SHA1/DES-CBC

From: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Pascal van Leeuwen <pascalvanl@gmail.com>,
	"open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
	<linux-crypto@vger.kernel.org>,
	Antoine Tenart <antoine.tenart@bootlin.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>
Subject: RE: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-SHA1/DES-CBC
Date: Fri, 13 Sep 2019 16:32:12 +0000	[thread overview]
Message-ID: <MN2PR20MB2973747D1984F453B007BBC5CAB30@MN2PR20MB2973.namprd20.prod.outlook.com> (raw)
In-Reply-To: <CAKv+Gu9-r3bKae_YNkvhWEwwS-GRUhp9qJn6+Lsgug97iGqS+A@mail.gmail.com>

> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: Friday, September 13, 2019 6:24 PM
> To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
> Cc: Pascal van Leeuwen <pascalvanl@gmail.com>; open list:HARDWARE RANDOM NUMBER
> GENERATOR CORE <linux-crypto@vger.kernel.org>; Antoine Tenart
> <antoine.tenart@bootlin.com>; Herbert Xu <herbert@gondor.apana.org.au>; David S. Miller
> <davem@davemloft.net>
> Subject: Re: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-
> SHA1/DES-CBC
> 
> On Fri, 13 Sep 2019 at 17:17, Pascal Van Leeuwen
> <pvanleeuwen@verimatrix.com> wrote:
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > Sent: Friday, September 13, 2019 5:27 PM
> > > To: Pascal van Leeuwen <pascalvanl@gmail.com>
> > > Cc: open list:HARDWARE RANDOM NUMBER GENERATOR CORE <linux-crypto@vger.kernel.org>;
> > > Antoine Tenart <antoine.tenart@bootlin.com>; Herbert Xu
> <herbert@gondor.apana.org.au>;
> > > David S. Miller <davem@davemloft.net>; Pascal Van Leeuwen
> <pvanleeuwen@verimatrix.com>
> > > Subject: Re: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-
> > > SHA1/DES-CBC
> > >
> > > On Fri, 13 Sep 2019 at 16:06, Pascal van Leeuwen <pascalvanl@gmail.com> wrote:
> > > >
> > > > This patch adds support for the authenc(hmac(sha1),cbc(des)) aead
> > > >
> > > > Signed-off-by: Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
> > >
> > > Please make sure your code is based on cryptodev/master before sending
> > > it to the list.
> > >
> > Looks like with this patchset and the previous (SHA3) patchset I forgot
> > to add the disclaimer that it applies on top of the previous patchset.
> > Mea culpa.
> >
> > So there you go: "Added support for authenc HMAC-SHA1/DES-CBC" applies
> > on top of "Added (HMAC) SHA3 support", which applies on top of
> > "Add support for SM4 ciphers".
> >
> 
> Sorry if I wasn't clear, but that was not my point.
> 
> You should really base your code on cryptodev/master since some of the
> DES helpers you are using don't exist anymore.
>
Ah, ok, I'll look into that ... I don't always notice that something
changed in cryptodev/master. Which doesn't happen too frequently, so
it's easy to miss. One of the downsides of Git compared to "normal"
version control systems: you have to manually keep track of master.

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com