From: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>,
"linux-kernel@lists.codethink.co.uk"
<linux-kernel@lists.codethink.co.uk>
Cc: Antoine Tenart <antoine.tenart@bootlin.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] crypto: inside-secure - fix type of buffer in eip197_write_firmware
Date: Thu, 17 Oct 2019 17:14:14 +0000 [thread overview]
Message-ID: <MN2PR20MB29739F7E3C145AB915E4A2DECA6D0@MN2PR20MB2973.namprd20.prod.outlook.com> (raw)
In-Reply-To: <20191016114945.30451-1-ben.dooks@codethink.co.uk>
> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.org> On Behalf Of Ben
> Dooks (Codethink)
> Sent: Wednesday, October 16, 2019 1:50 PM
> To: linux-kernel@lists.codethink.co.uk
> Cc: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>; Antoine Tenart
> <antoine.tenart@bootlin.com>; Herbert Xu <herbert@gondor.apana.org.au>; David S. Miller
> <davem@davemloft.net>; linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] crypto: inside-secure - fix type of buffer in eip197_write_firmware
>
> In eip197_write_firmware() the firmware buffer is sent using
> writel(be32_to_cpu(),,,) this produces a number of warnings.
>
> Note, should this really be cpu_to_be32() ?
>
No, it should certainly not be cpu_to_be32() since the HW itself is most
definitely little endian, so that would not make sense to me.
Actually, I don't think either solution would be correct on a big-endian
CPU. But I don't have any big-endian CPU available to test that theory.
What I believe must happen is that the bytes must *always* be swapped
here, regardless of the endianness of the CPU. And with a little-endian
CPU, be32_to_cpu() coincidentally always does that.
Basically, what we need here is: read a dword (32 bits) from the memory
subsystem and write it back to the memory subsystem with bytes reversed.
Does the kernel have any dedicated function for just always swapping?
Anyway: NACK on this patch for now due to this.
> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restricted __be32
> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restricted __be32
> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restricted __be32
> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restricted __be32
> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restricted __be32
> drivers/crypto/inside-secure/safexcel.c:306:17: warning: cast to restricted __be32
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Antoine Tenart <antoine.tenart@bootlin.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/crypto/inside-secure/safexcel.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
> index 223d1bfdc7e6..dd33f6dda295 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -298,13 +298,13 @@ static void eip197_init_firmware(struct safexcel_crypto_priv *priv)
> static int eip197_write_firmware(struct safexcel_crypto_priv *priv,
> const struct firmware *fw)
> {
> - const u32 *data = (const u32 *)fw->data;
> + const __be32 *data = (const __be32 *)fw->data;
> int i;
>
> /* Write the firmware */
> - for (i = 0; i < fw->size / sizeof(u32); i++)
> + for (i = 0; i < fw->size / sizeof(__be32); i++)
> writel(be32_to_cpu(data[i]),
> - priv->base + EIP197_CLASSIFICATION_RAMS + i * sizeof(u32));
> + priv->base + EIP197_CLASSIFICATION_RAMS + i * sizeof(__be32));
>
> /* Exclude final 2 NOPs from size */
> return i - EIP197_FW_TERMINAL_NOPS;
> --
> 2.23.0
Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com
next prev parent reply other threads:[~2019-10-17 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 11:49 [PATCH] crypto: inside-secure - fix type of buffer in eip197_write_firmware Ben Dooks (Codethink)
2019-10-17 17:14 ` Pascal Van Leeuwen [this message]
2019-10-17 19:46 ` Pascal Van Leeuwen
2019-10-21 10:23 ` Pascal Van Leeuwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR20MB29739F7E3C145AB915E4A2DECA6D0@MN2PR20MB2973.namprd20.prod.outlook.com \
--to=pvanleeuwen@verimatrix.com \
--cc=antoine.tenart@bootlin.com \
--cc=ben.dooks@codethink.co.uk \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).