From: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: YueHaibing <yuehaibing@huawei.com>,
"antoine.tenart@bootlin.com" <antoine.tenart@bootlin.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"pvanleeuwen@insidesecure.com" <pvanleeuwen@insidesecure.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 -next] crypto: inside-secure - Fix build error without CONFIG_PCI
Date: Wed, 4 Sep 2019 12:45:00 +0000 [thread overview]
Message-ID: <MN2PR20MB2973A03BFD630B654A46ACB8CAB80@MN2PR20MB2973.namprd20.prod.outlook.com> (raw)
In-Reply-To: <20190904123158.GA29870@gondor.apana.org.au>
So, with that patch you ONLY get a warning on that unused int rc, right?
I do understand that one, that should have been inside an #ifdef as well.
Everybody happy if I just fix that and leave the rest as is?
Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com
> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Wednesday, September 4, 2019 2:32 PM
> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>; YueHaibing <yuehaibing@huawei.com>;
> antoine.tenart@bootlin.com; davem@davemloft.net; pvanleeuwen@insidesecure.com; linux-
> crypto@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 -next] crypto: inside-secure - Fix build error without CONFIG_PCI
>
> On Wed, Sep 04, 2019 at 05:27:19AM -0700, Ard Biesheuvel wrote:
> >
> > Did you try disabling CONFIG_PCI?
>
> Indeed. Even with my patch if you compile with CONFIG_PCI you still
> get a warning:
>
> CC [M] drivers/crypto/inside-secure/safexcel.o
> ../drivers/crypto/inside-secure/safexcel.c: In function \u2018safexcel_init\u2019:
> ../drivers/crypto/inside-secure/safexcel.c:1506:6: warning: unused variable \u2018rc\u2019
> [-Wunused-variable]
> int rc;
> ^~
>
> We should fix that in inside-secure.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-09-04 12:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 14:19 [PATCH -next] crypto: inside-secure - Fix build error without CONFIG_PCI YueHaibing
2019-09-03 1:32 ` Ard Biesheuvel
2019-09-03 1:45 ` [PATCH v2 " YueHaibing
2019-09-04 11:57 ` Pascal Van Leeuwen
2019-09-04 12:10 ` Ard Biesheuvel
2019-09-04 12:25 ` Pascal Van Leeuwen
2019-09-04 12:27 ` Ard Biesheuvel
2019-09-04 12:31 ` Herbert Xu
2019-09-04 12:45 ` Pascal Van Leeuwen [this message]
2019-09-04 13:08 ` Herbert Xu
2019-09-04 12:43 ` Pascal Van Leeuwen
2019-09-04 12:26 ` PCI: Add stub pci_irq_vector and others Herbert Xu
2019-09-04 14:33 ` Yuehaibing
2019-09-05 21:07 ` Bjorn Helgaas
2019-09-05 22:53 ` Herbert Xu
2019-09-20 19:42 ` Bjorn Helgaas
2019-09-20 23:16 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR20MB2973A03BFD630B654A46ACB8CAB80@MN2PR20MB2973.namprd20.prod.outlook.com \
--to=pvanleeuwen@verimatrix.com \
--cc=antoine.tenart@bootlin.com \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pvanleeuwen@insidesecure.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).