linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Gong <yibin.gong@nxp.com>
To: "André Draszik" <git@andred.net>
Cc: Horia Geanta <horia.geanta@nxp.com>,
	Aymen Sghaier <aymen.sghaier@nxp.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Anson Huang <anson.huang@nxp.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 6/6] Input: snvs_pwrkey - only IRQ_HANDLED for our own events
Date: Sat, 29 Feb 2020 10:05:58 +0000	[thread overview]
Message-ID: <VE1PR04MB66385D4CA35122C3D043B86789E90@VE1PR04MB6638.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <f3c4f7791c86235683541a3d51ed02631b784bf6.camel@andred.net>

On 2020/02/27 André Draszik <git@andred.net> wrote:
> On Wed, 2020-02-26 at 01:15 +0000, Robin Gong wrote:
> > On 2020/02/26 André Draszik <git@andred.net> wrote:
> > > The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc.
> > >
> > > This driver here should only return IRQ_HANDLED if the status
> > > register indicates that the event we're handling in the irq handler
> > > was genuinely intended for this driver. Otheriwse the interrupt
> > > subsystem will assume the interrupt was handled successfully even though
> it wasn't at all.
> > >
> > > Signed-off-by: André Draszik <git@andred.net>
> > > Cc: "Horia Geantă" <horia.geanta@nxp.com>
> > > Cc: Aymen Sghaier <aymen.sghaier@nxp.com>
> > > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > > Cc: "David S. Miller" <davem@davemloft.net>
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > > Cc: Fabio Estevam <festevam@gmail.com>
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > Cc: Anson Huang <Anson.Huang@nxp.com>
> > > Cc: Robin Gong <yibin.gong@nxp.com>
> > > Cc: linux-crypto@vger.kernel.org
> > > Cc: devicetree@vger.kernel.org
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > Cc: linux-input@vger.kernel.org
> > >
> > > ---
> > > v2:
> > > * no changes
> > > ---
> > >  drivers/input/keyboard/snvs_pwrkey.c | 12 +++++++-----
> > >  1 file changed, 7 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/input/keyboard/snvs_pwrkey.c
> > > b/drivers/input/keyboard/snvs_pwrkey.c
> > > index 382d2ae82c9b..980867886b34 100644
> > > --- a/drivers/input/keyboard/snvs_pwrkey.c
> > > +++ b/drivers/input/keyboard/snvs_pwrkey.c
> > > @@ -82,7 +82,9 @@ static irqreturn_t imx_snvs_pwrkey_interrupt(int
> > > irq, void
> > > *dev_id)
> > >  	clk_enable(pdata->clk);
> > >
> > >  	regmap_read(pdata->snvs, SNVS_LPSR_REG, &lp_status);
> > > -	if (lp_status & SNVS_LPSR_SPO) {
> > > +	lp_status &= SNVS_LPSR_SPO;
> > > +
> > > +	if (lp_status) {
> > >  		if (pdata->minor_rev == 0) {
> > >  			/*
> > >  			 * The first generation i.MX[6|7] SoCs only send an @@
> -98,14
> > > +100,14 @@ static irqreturn_t imx_snvs_pwrkey_interrupt(int irq,
> > > +void
> > > *dev_id)
> > >  			mod_timer(&pdata->check_timer,
> > >  			          jiffies + msecs_to_jiffies(DEBOUNCE_TIME));
> > >  		}
> > > -	}
> > >
> > > -	/* clear SPO status */
> > > -	regmap_write(pdata->snvs, SNVS_LPSR_REG, SNVS_LPSR_SPO);
> > > +		/* clear SPO status */
> > > +		regmap_write(pdata->snvs, SNVS_LPSR_REG, SNVS_LPSR_SPO);
> > But irq storm will come in once there is other interrupt triggered as
> > unexpected, although I never met it before. Could we drop this patch now?
> Others are ok for me.
> 
> I don't have strong feelings about this patch, but this bit merely changes
> behaviour to clear SP0 if SP0 was in fact != 0 in the first place, whereas before
> SP0 was always cleared, even if it was == 0 anyway. Seems more logical in my
> eyes.
Seems we care something never happen:) I'm okay if you really want to do that.
> 
> 
> > Reviewed-by: Robin Gong <yibin.gong@nxp>
> > > +	}
> > >
> > >  	clk_disable(pdata->clk);
> > >
> > > -	return IRQ_HANDLED;
> > > +	return lp_status ? IRQ_HANDLED : IRQ_NONE;
> 
> If you're talking about this part, the rtc-snvs driver does the same in its
> interrupt handler.
> In other words, this driver here could prevent the rtc-snvs driver from seeing its
> events
But rtc driver has another interrupt number, and snvs_pwrkey driver just touch SPO bit
as below:
regmap_write(pdata->snvs, SNVS_LPSR_REG, SNVS_LPSR_SPO);
So I don't think it could impact rtc-snvs driver. But you remind me rtc-snvs driver may clear SPO status, because lpsr is read from SNVS_LPSR which may SPO has already been set.
regmap_write(data->regmap, data->offset + SNVS_LPSR, lpsr);
I'll send a patch for fix that potential issue. Besides, if you really want to follow rtc driver please initialize lp_status with 0.  
> 
> 
> 
> Cheers,
> Andre'
> 
> 
> > >  }
> > >
> > >  static void imx_snvs_pwrkey_act(void *pdata)
> > > --
> > > 2.23.0.rc1


  reply	other threads:[~2020-02-29 10:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 16:11 [PATCH v2 1/6] dt-bindings: crypto: fsl-sec4: add snvs clock to pwrkey André Draszik
2020-02-25 16:11 ` [PATCH v2 2/6] ARM: dts: imx7s: " André Draszik
2020-03-11  6:43   ` Shawn Guo
2020-02-25 16:11 ` [PATCH v2 3/6] arm64: dts: imx8mm: " André Draszik
2020-03-11  6:47   ` Shawn Guo
2020-02-25 16:11 ` [PATCH v2 4/6] arm64: dts: imx8mq: " André Draszik
2020-03-11  6:47   ` Shawn Guo
2020-02-25 16:12 ` [PATCH v2 5/6] Input: snvs_pwrkey - enable snvs clock as needed André Draszik
2020-02-25 16:12 ` [PATCH v2 6/6] Input: snvs_pwrkey - only IRQ_HANDLED for our own events André Draszik
2020-02-26  1:15   ` Robin Gong
2020-02-26 17:23     ` André Draszik
2020-02-29 10:05       ` Robin Gong [this message]
2020-03-02  9:22   ` Horia Geanta
2020-03-28  3:43     ` Adam Ford
2020-04-01  8:58       ` Horia Geantă
2020-04-15 16:57         ` Horia Geantă
2020-03-02  8:17 ` [PATCH v2 1/6] dt-bindings: crypto: fsl-sec4: add snvs clock to pwrkey Horia Geanta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR04MB66385D4CA35122C3D043B86789E90@VE1PR04MB6638.eurprd04.prod.outlook.com \
    --to=yibin.gong@nxp.com \
    --cc=anson.huang@nxp.com \
    --cc=aymen.sghaier@nxp.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=festevam@gmail.com \
    --cc=git@andred.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --subject='RE: [PATCH v2 6/6] Input: snvs_pwrkey - only IRQ_HANDLED for our own events' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).