linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Horia Geanta <horia.geanta@nxp.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: Chris Healy <cphealy@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Iuliana Prodan <iuliana.prodan@nxp.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] crypto: caam - use static initialization
Date: Wed, 20 Nov 2019 07:06:09 +0000	[thread overview]
Message-ID: <VI1PR0402MB34852B194D4CB5051732AD41984F0@VI1PR0402MB3485.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20191105151353.6522-2-andrew.smirnov@gmail.com

On 11/5/2019 5:14 PM, Andrey Smirnov wrote:
> @@ -589,8 +592,6 @@ static struct platform_driver caam_jr_driver = {
>  
>  static int __init jr_driver_init(void)
>  {
> -	spin_lock_init(&driver_data.jr_alloc_lock);
> -	INIT_LIST_HEAD(&driver_data.jr_list);
>  	return platform_driver_register(&caam_jr_driver);
>  }
>  
And with this change, jr_driver_{init,exit} could be replaced with
	module_platform_driver(caam_jr_driver);

It's probably worth adding this here even if we later decide
that moving away from platform driver for jr is the way to go.

Horia

  reply	other threads:[~2019-11-20  7:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 15:13 [PATCH 0/5] CAAM JR lifecycle Andrey Smirnov
2019-11-05 15:13 ` [PATCH 1/5] crypto: caam - use static initialization Andrey Smirnov
2019-11-20  7:06   ` Horia Geanta [this message]
2019-11-05 15:13 ` [PATCH 2/5] crypto: caam - introduce caam_jr_cbk Andrey Smirnov
2019-11-20  7:09   ` Horia Geanta
2019-11-05 15:13 ` [PATCH 3/5] crypto: caam - convert JR API to use struct caam_drv_private_jr Andrey Smirnov
2019-11-06  9:04   ` kbuild test robot
2019-11-05 15:13 ` [PATCH 4/5] crypto: caam - do not create a platform devices for JRs Andrey Smirnov
2019-11-05 15:13 ` [PATCH 5/5] crypto: caam - disable CAAM's bind/unbind attributes Andrey Smirnov
2019-11-06  7:27 ` [PATCH 0/5] CAAM JR lifecycle Vakul Garg
2019-11-06 15:19   ` Andrey Smirnov
2019-11-13 18:57     ` Horia Geanta
2019-11-13 19:25       ` Andrey Smirnov
2019-11-17  6:15         ` Andrey Smirnov
2020-01-08 15:50           ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0402MB34852B194D4CB5051732AD41984F0@VI1PR0402MB3485.eurprd04.prod.outlook.com \
    --to=horia.geanta@nxp.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=cphealy@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=iuliana.prodan@nxp.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).