linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Horia Geanta <horia.geanta@nxp.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Roy Pledge <roy.pledge@nxp.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Aymen Sghaier <aymen.sghaier@nxp.com>,
	Leo Li <leoyang.li@nxp.com>,
	Madalin-cristian Bucur <madalin.bucur@nxp.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: caam/qi - simplify CGR allocation, freeing
Date: Thu, 25 Oct 2018 14:05:32 +0000	[thread overview]
Message-ID: <VI1PR0402MB3485A342A184BEBB004E74F998F70@VI1PR0402MB3485.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20181009171101.jk6lgdx4g5rnq7cm@linutronix.de>

On 10/9/2018 8:11 PM, Sebastian Andrzej Siewior wrote:
> On 2018-10-08 14:09:37 [+0300], Horia Geantă wrote:
>> CGRs (Congestion Groups) have to be freed by the same CPU that
>> initialized them.
>> This is why currently the driver takes special measures; however, using
>> set_cpus_allowed_ptr() is incorrect - as reported by Sebastian.
>>
>> Instead of the generic solution of replacing set_cpus_allowed_ptr() with
>> work_on_cpu_safe(), we use the qman_delete_cgr_safe() QBMan API instead
>> of qman_delete_cgr() - which internally takes care of proper CGR
>> deletion.
>>
>> Link: https://lkml.kernel.org/r/20181005125443.dfhd2asqktm22ney@linutronix.de
>> Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> 
> Oh. No more usage of set_cpus_allowed_ptr(). Wonderful. Thank you.
>  Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> for that.
> 
> Now that you shifted my attention to qman_delete_cgr_safe().
> Could you please use work_on_cpu_safe() here instead
> smp_call_function_single() with preempt_disable() around it?
> 
> Now, what is the problem with the CPU limitation? Is this a HW
> limitation that you can access the registers from a certain CPU?
> 
Roy confirmed the CPU limitation should actually be removed, there is nothing in
HW requiring it.
A clean-up patch will follow.

Thanks,
Horia

  reply	other threads:[~2018-10-25 22:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 12:54 set_cpus_allowed_ptr() usage in FREESCALE CAAM Sebastian Andrzej Siewior
2018-10-08 11:09 ` [PATCH] crypto: caam/qi - simplify CGR allocation, freeing Horia Geantă
2018-10-09 17:11   ` Sebastian Andrzej Siewior
2018-10-25 14:05     ` Horia Geanta [this message]
2018-10-29  8:56       ` Sebastian Andrzej Siewior
2018-10-17  6:21   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0402MB3485A342A184BEBB004E74F998F70@VI1PR0402MB3485.eurprd04.prod.outlook.com \
    --to=horia.geanta@nxp.com \
    --cc=aymen.sghaier@nxp.com \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=leoyang.li@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=peterz@infradead.org \
    --cc=roy.pledge@nxp.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] crypto: caam/qi - simplify CGR allocation, freeing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox