archive mirror
 help / color / mirror / Atom feed
From: Iuliana Prodan <>
To: Herbert Xu <>
Cc: Baolin Wang <>,
	Ard Biesheuvel <>,
	Corentin Labbe <>,
	Horia Geanta <>,
	Maxime Coquelin <>,
	Alexandre Torgue <>,
	Maxime Ripard <>,
	Aymen Sghaier <>,
	"David S. Miller" <>,
	Silvano Di Ninno <>,
	Franck Lenormand <>,
	"" <>,
	"" <>,
	dl-linux-imx <>
Subject: Re: [PATCH v5 2/3] crypto: engine - support for parallel requests based on retry mechanism
Date: Fri, 24 Apr 2020 14:34:57 +0000	[thread overview]
Message-ID: <> (raw)

On 4/23/2020 2:47 PM, Herbert Xu wrote:
> On Wed, Apr 15, 2020 at 11:26:14PM +0300, Iuliana Prodan wrote:
>> Added support for executing multiple requests, in parallel,
>> for crypto engine based on a retry mechanism.
>> If hardware was unable to execute a backlog request, enqueue it
>> back in front of crypto-engine queue, to keep the order
>> of requests.
>> A new variable is added, retry_support (this is to keep the
>> backward compatibility of crypto-engine) , which keeps track
>> whether the hardware has support for retry mechanism and,
>> also, if can run multiple requests.
>> If do_one_request() returns:
>>> = 0: hardware executed the request successfully;
>> < 0: this is the old error path. If hardware has support for retry
>> mechanism, the request is put back in front of crypto-engine queue.
>> For backwards compatibility, if the retry support is not available,
>> the crypto-engine will work as before.
>> Only MAY_BACKLOG requests are enqueued back into
>> crypto-engine's queue, since the others can be dropped.
> This looks a lot nicer!
> However, I do have one little issue with the error case.  I think
> we should not lump all errors together.  For queueing errors, we
> should requeue regardless of MAY_BACKLOG.  After all, we don't
> want to have random packet loss just becayse the queue was full.
> For other errors (e.g., a kmalloc error), we should requeue the
> MAY_BACKLOG requests and drop everythin else.

Do you refer to the error codes returned by do_one_request (which sends 
the req to hw for execution)?

If this returns:
1. 0, success;
2. -ENOSPC, I'll requeue it regardless of MAY_BACKLOG;
3. any other error (-EIO, -EINVAL, -ENOMEM, etc), I'll requeue only 
MAY_BACKLOG requests.


  reply	other threads:[~2020-04-24 14:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 20:26 [PATCH v5 0/3] crypto: engine - support for parallel and batch requests Iuliana Prodan
2020-04-15 20:26 ` [PATCH v5 1/3] crypto: algapi - create function to add request in front of queue Iuliana Prodan
2020-04-15 20:26 ` [PATCH v5 2/3] crypto: engine - support for parallel requests based on retry mechanism Iuliana Prodan
2020-04-23 11:46   ` Herbert Xu
2020-04-24 14:34     ` Iuliana Prodan [this message]
2020-04-24 15:10       ` Herbert Xu
2020-04-15 20:26 ` [PATCH v5 3/3] crypto: engine - support for batch requests Iuliana Prodan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).