From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89358C433FE for ; Fri, 4 Nov 2022 09:05:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230132AbiKDJFt (ORCPT ); Fri, 4 Nov 2022 05:05:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231150AbiKDJFs (ORCPT ); Fri, 4 Nov 2022 05:05:48 -0400 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93B0C29C94; Fri, 4 Nov 2022 02:05:47 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oqsdQ-00A1bz-GQ; Fri, 04 Nov 2022 17:05:45 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 04 Nov 2022 17:05:44 +0800 Date: Fri, 4 Nov 2022 17:05:44 +0800 From: Herbert Xu To: Kai Ye Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] crypto: hisilicon/qm - modify the process of regs dfx Message-ID: References: <20221029094801.43843-1-yekai13@huawei.com> <20221029094801.43843-2-yekai13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221029094801.43843-2-yekai13@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Oct 29, 2022 at 09:47:59AM +0000, Kai Ye wrote: > > diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c > index 363a02810a16..832cfd9a7728 100644 > --- a/drivers/crypto/hisilicon/qm.c > +++ b/drivers/crypto/hisilicon/qm.c > @@ -1722,8 +1722,22 @@ static int qm_regs_show(struct seq_file *s, void *unused) > > DEFINE_SHOW_ATTRIBUTE(qm_regs); > > +static void dfx_regs_uninit(struct hisi_qm *qm, > + struct dfx_diff_registers *dregs, int reg_len) > +{ > + int i; > + > + /* Setting the pointer is NULL to prevent double free */ > + for (i = 0; i < reg_len; i++) { > + kfree(dregs[i].regs); > + dregs[i].regs = NULL; > + } > + kfree(dregs); > + dregs = NULL; What's the point of this last NULL assignment? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt