From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4574DC46467 for ; Tue, 29 Nov 2022 08:26:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230214AbiK2I0l (ORCPT ); Tue, 29 Nov 2022 03:26:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229798AbiK2I0k (ORCPT ); Tue, 29 Nov 2022 03:26:40 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48F5B56EF1 for ; Tue, 29 Nov 2022 00:26:38 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id z20so18710197edc.13 for ; Tue, 29 Nov 2022 00:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pgrzkkklPcAQYmyQMmCpEE1o3a9ohgeq3WVDc+0vm08=; b=XiAjLYS5j4RwLKJGZxfsDINusHr9CRwW/Y3flS/dZFlY4O60OTBiKSUQjxvGIX+3Rg dWAJ1ca2t+K0d+bi0hYAhKvXStoidmphxQ0TDLO6BSnIL0/DN3PnlJFDIMFRt3mXIa4g ZMPEl75jJykR9z7KbG5TQ2wepgiS9FlevG8+O0tg70kUd7KYg2ugRDQg84wgWnAptk9T NHGqa/dI8nJ2hDhtgvRxfieYv/2wyABK91GuDzW2R+fCWgqEG0yJvCUyqY3kdcbZmt0P gS7yCTuTDX6ORTNxuGB1qv1ErmB0M7sxgSP6i5oaQm/rCTvkHAkTwlvZFSa7282d1MRL RrTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pgrzkkklPcAQYmyQMmCpEE1o3a9ohgeq3WVDc+0vm08=; b=RndZXmRSNiaM/VgTmLVFdVIFEMVcvOxjYl6njpG4ewUg7+tw5Lsd+b8oBELoEINwgx qUZCclhhRvjGIM7X8X4NJI807/dehylMxxn5pGxfLaMZUqIbu5MZsLmJo3hR7TnGMGGA N9Oh+PScqlrnnuAMeYmGwSqzxtcjr6El2R5W0yOcfyxSu08gz+vWBH+qCYOnO6+I/mfs uzqYShmuOq7E3Oy/9siij92wW/rCmyGW3vf4YbtfiUVgyNgS6fOq+fmgDEjUy7cdJbtY kxDuo7CApE+ATtVnaJeyOHv0rIlRW/ZEgB+jxmA1iceAycnREsJTrP2n8djk1XNWkioP 9Qvw== X-Gm-Message-State: ANoB5pmJP5/hYitU/SznXt60zXUKhTfHmTs6Iz31lSEL5pBFRhqT0d9/ lXzENlO/d34cOyVpWJ+2v6bFBg== X-Google-Smtp-Source: AA0mqf6AhCTZUtOfuGYDhXfqaKP0HI3CcryljG1Et3fvW7wqzGVxjYaxttb++c6crBKvAOdrZVKVcw== X-Received: by 2002:a05:6402:1f14:b0:461:c7ef:b09e with SMTP id b20-20020a0564021f1400b00461c7efb09emr37432404edb.58.1669710397245; Tue, 29 Nov 2022 00:26:37 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id r9-20020a50aac9000000b00461c6e8453dsm6017247edc.23.2022.11.29.00.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 00:26:36 -0800 (PST) Date: Tue, 29 Nov 2022 09:26:35 +0100 From: Jiri Pirko To: Vincent Mailhol Cc: Jiri Pirko , netdev@vger.kernel.org, Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org, Boris Brezillon , Arnaud Ebalard , Srujana Challa , Kurt Kanzenbach , Andrew Lunn , Florian Fainelli , Vladimir Oltean , Michael Chan , Ioana Ciornei , Dimitris Michailidis , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Sunil Goutham , Linu Cherian , Geetha sowjanya , Jerin Jacob , hariprasad , Subbaraya Sundeep , Taras Chornyi , Saeed Mahameed , Leon Romanovsky , Ido Schimmel , Petr Machata , Simon Horman , Shannon Nelson , drivers@pensando.io, Ariel Elior , Manish Chopra , Jonathan Lemon , Vadim Fedorenko , Richard Cochran , Vadim Pasternak , Shalom Toledo , linux-crypto@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, Jiri Pirko , Herbert Xu , Hao Chen , Guangbin Huang , Minghao Chi , Shijith Thotton Subject: Re: [PATCH net-next v5 3/4] net: devlink: make the devlink_ops::info_get() callback optional Message-ID: References: <20221129000550.3833570-1-mailhol.vincent@wanadoo.fr> <20221129000550.3833570-4-mailhol.vincent@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221129000550.3833570-4-mailhol.vincent@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Tue, Nov 29, 2022 at 01:05:49AM CET, mailhol.vincent@wanadoo.fr wrote: >Some drivers only reported the driver name in their >devlink_ops::info_get() callback. Now that the core provides this >information, the callback became empty. For such drivers, just >removing the callback would prevent the core from executing >devlink_nl_info_fill() meaning that "devlink dev info" would not >return anything. > >Make the callback function optional by executing >devlink_nl_info_fill() even if devlink_ops::info_get() is NULL. > >N.B.: the drivers with devlink support which previously did not >implement devlink_ops::info_get() will now also be able to report >the driver name. > >Signed-off-by: Vincent Mailhol Reviewed-by: Jiri Pirko