From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Vitaly Chikunov <vt@altlinux.org>,
Eric Biggers <ebiggers@google.com>,
Eric Biggers <ebiggers@kernel.org>,
Gilad Ben-Yossef <gilad@benyossef.com>,
Ard Biesheuvel <ardb@kernel.org>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-crypto@vger.kernel.org, x86@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/6] crypto: arm64/sm3-ce - make dependent on sm3 library
Date: Fri, 7 Jan 2022 14:28:53 +1100 [thread overview]
Message-ID: <YdezdZQHZT2+iYV3@gondor.apana.org.au> (raw)
In-Reply-To: <20211223043547.32297-3-tianjia.zhang@linux.alibaba.com>
On Thu, Dec 23, 2021 at 12:35:43PM +0800, Tianjia Zhang wrote:
> SM3 generic library is stand-alone implementation, sm3-ce can depend
> on the SM3 library instead of sm3-generic.
>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> ---
> arch/arm64/crypto/Kconfig | 2 +-
> arch/arm64/crypto/sm3-ce-glue.c | 20 ++++++++++++++------
> 2 files changed, 15 insertions(+), 7 deletions(-)
This doesn't compile cleanly with C=1 W=1:
CC [M] arch/arm64/crypto/sm3-ce-glue.o
AS [M] arch/arm64/crypto/sm3-ce-core.o
CC [M] arch/arm64/crypto/sm4-ce-glue.o
CHECK ../arch/arm64/crypto/sha3-ce-glue.c
../arch/arm64/crypto/sm3-ce-glue.c: In function ‘sm3_ce_update’:
../arch/arm64/crypto/sm3-ce-glue.c:30:10: error: void value not ignored as it ought to be
30 | return sm3_update(shash_desc_ctx(desc), data, len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../arch/arm64/crypto/sm3-ce-glue.c: In function ‘sm3_ce_final’:
../arch/arm64/crypto/sm3-ce-glue.c:42:10: error: void value not ignored as it ought to be
42 | return sm3_final(shash_desc_ctx(desc), out);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [../scripts/Makefile.build:287: arch/arm64/crypto/sm3-ce-glue.o] Error 1
make[3]: *** Waiting for unfinished jobs....
Please make sure everything builds cleanly with C=1 W=1 *before*
you submit.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-01-07 3:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 4:35 [PATCH v3 0/6] Introduce x86 assembly accelerated implementation for SM3 algorithm Tianjia Zhang
2021-12-23 4:35 ` [PATCH v3 1/6] crypto: sm3 - create SM3 stand-alone library Tianjia Zhang
2021-12-23 4:35 ` [PATCH v3 2/6] crypto: arm64/sm3-ce - make dependent on sm3 library Tianjia Zhang
2022-01-07 3:28 ` Herbert Xu [this message]
2022-01-07 8:57 ` Tianjia Zhang
2021-12-23 4:35 ` [PATCH v3 3/6] crypto: sm2 " Tianjia Zhang
2021-12-23 4:35 ` [PATCH v3 4/6] crypto: sm3 " Tianjia Zhang
2021-12-23 4:35 ` [PATCH v3 5/6] crypto: x86/sm3 - add AVX assembly implementation Tianjia Zhang
2021-12-23 4:35 ` [PATCH v3 6/6] crypto: tcrypt - add asynchronous speed test for SM3 Tianjia Zhang
2021-12-23 10:28 ` [PATCH v3 0/6] Introduce x86 assembly accelerated implementation for SM3 algorithm Borislav Petkov
2021-12-24 10:01 ` Tianjia Zhang
2021-12-24 13:00 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdezdZQHZT2+iYV3@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=ebiggers@kernel.org \
--cc=gilad@benyossef.com \
--cc=hpa@zytor.com \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=vt@altlinux.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).