linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Nathan Huckleberry <nhuck@google.com>
Cc: linux-crypto@vger.kernel.org, linux-fscrypt@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	Paul Crowley <paulcrowley@google.com>,
	Eric Biggers <ebiggers@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v8 8/9] crypto: arm64/polyval: Add PMULL accelerated implementation of POLYVAL
Date: Fri, 20 May 2022 13:53:43 +0800	[thread overview]
Message-ID: <Yocs5y9rvJJ+eI6C@gondor.apana.org.au> (raw)
In-Reply-To: <20220510172359.3720527-9-nhuck@google.com>

On Tue, May 10, 2022 at 05:23:58PM +0000, Nathan Huckleberry wrote:
>
> +module_cpu_feature_match(PMULL, polyval_ce_mod_init)
> +
> +module_init(polyval_ce_mod_init);

I get a cross-compile failure on this:

In file included from ../arch/arm64/crypto/polyval-ce-glue.c:25:
../include/linux/module.h:131:42: error: redefinition of ‘__inittest’
  131 |  static inline initcall_t __maybe_unused __inittest(void)  \
      |                                          ^~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:187:1: note: in expansion of macro ‘module_init’
  187 | module_init(polyval_ce_mod_init);
      | ^~~~~~~~~~~
../include/linux/module.h:131:42: note: previous definition of ‘__inittest’ was here
  131 |  static inline initcall_t __maybe_unused __inittest(void)  \
      |                                          ^~~~~~~~~~
../include/linux/cpufeature.h:55:1: note: in expansion of macro ‘module_init’
   55 | module_init(cpu_feature_match_ ## x ## _init)
      | ^~~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:185:1: note: in expansion of macro ‘module_cpu_feature_match’
  185 | module_cpu_feature_match(PMULL, polyval_ce_mod_init)
      | ^~~~~~~~~~~~~~~~~~~~~~~~
../include/linux/module.h:133:6: error: redefinition of ‘init_module’
  133 |  int init_module(void) __copy(initfn)   \
      |      ^~~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:187:1: note: in expansion of macro ‘module_init’
  187 | module_init(polyval_ce_mod_init);
      | ^~~~~~~~~~~
../include/linux/module.h:133:6: note: previous definition of ‘init_module’ was here
  133 |  int init_module(void) __copy(initfn)   \
      |      ^~~~~~~~~~~
../include/linux/cpufeature.h:55:1: note: in expansion of macro ‘module_init’
   55 | module_init(cpu_feature_match_ ## x ## _init)
      | ^~~~~~~~~~~
../arch/arm64/crypto/polyval-ce-glue.c:185:1: note: in expansion of macro ‘module_cpu_feature_match’
  185 | module_cpu_feature_match(PMULL, polyval_ce_mod_init)
      | ^~~~~~~~~~~~~~~~~~~~~~~~

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2022-05-20  5:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 17:23 [PATCH v8 0/9] crypto: HCTR2 support Nathan Huckleberry
2022-05-10 17:23 ` [PATCH v8 1/9] crypto: xctr - Add XCTR support Nathan Huckleberry
2022-05-10 17:23 ` [PATCH v8 2/9] crypto: polyval - Add POLYVAL support Nathan Huckleberry
2022-05-10 17:23 ` [PATCH v8 3/9] crypto: hctr2 - Add HCTR2 support Nathan Huckleberry
2022-05-10 17:23 ` [PATCH v8 4/9] crypto: x86/aesni-xctr: Add accelerated implementation of XCTR Nathan Huckleberry
2022-05-10 17:23 ` [PATCH v8 5/9] crypto: arm64/aes-xctr: " Nathan Huckleberry
2022-05-10 17:23 ` [PATCH v8 6/9] crypto: arm64/aes-xctr: Improve readability of XCTR and CTR modes Nathan Huckleberry
2022-05-10 17:23 ` [PATCH v8 7/9] crypto: x86/polyval: Add PCLMULQDQ accelerated implementation of POLYVAL Nathan Huckleberry
2022-05-10 17:23 ` [PATCH v8 8/9] crypto: arm64/polyval: Add PMULL " Nathan Huckleberry
2022-05-20  5:53   ` Herbert Xu [this message]
2022-05-10 17:23 ` [PATCH v8 9/9] fscrypt: Add HCTR2 support for filename encryption Nathan Huckleberry
2022-05-10 19:05 ` [PATCH v8 0/9] crypto: HCTR2 support Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yocs5y9rvJJ+eI6C@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=ardb@kernel.org \
    --cc=davem@davemloft.net \
    --cc=ebiggers@google.com \
    --cc=ebiggers@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=nhuck@google.com \
    --cc=paulcrowley@google.com \
    --cc=samitolvanen@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).