linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-crypto@vger.kernel.org,
	Harald Freudenberger <freude@linux.ibm.com>
Subject: Re: [PATCH crypto 5.19] crypto: s390 - do not depend on CRYPTO_HW for SIMD implementations
Date: Tue, 5 Jul 2022 10:39:35 +0800	[thread overview]
Message-ID: <YsOkZ1EdIkodYVBG@gondor.apana.org.au> (raw)
In-Reply-To: <20220705014653.111335-1-Jason@zx2c4.com>

On Tue, Jul 05, 2022 at 03:46:53AM +0200, Jason A. Donenfeld wrote:
> Various accelerated software implementation Kconfig values for S390 were
> mistakenly placed into drivers/crypto/Kconfig, even though they're
> mainly just SIMD code and live in arch/s390/crypto/ like usual. This
> gives them the very unusual dependency on CRYPTO_HW, which leads to
> problems elsewhere.
> 
> This patch fixes the issue by moving the Kconfig values for non-hardware
> drivers into the usual place in crypto/Kconfig.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
>  crypto/Kconfig         | 114 ++++++++++++++++++++++++++++++++++++++++
>  drivers/crypto/Kconfig | 115 -----------------------------------------
>  2 files changed, 114 insertions(+), 115 deletions(-)

This is caused by the s390 patch for wireguard, right?

As such it's a new feature and I don't see why it needs to go
in right away.  Having said that, if you insist I'm happy for
you take this into your tree along with the wireguard patch
where it would make more sense.

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

I've also added CCs to the s390 maintainers.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2022-07-05  2:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05  1:46 [PATCH crypto 5.19] crypto: s390 - do not depend on CRYPTO_HW for SIMD implementations Jason A. Donenfeld
2022-07-05  2:39 ` Herbert Xu [this message]
2022-07-05 13:06   ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsOkZ1EdIkodYVBG@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=Jason@zx2c4.com \
    --cc=freude@linux.ibm.com \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).