From: Herbert Xu <herbert@gondor.apana.org.au>
To: shangxiaojing <shangxiaojing@huawei.com>
Cc: Neal Liu <neal_liu@aspeedtech.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"joel@jms.id.au" <joel@jms.id.au>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] crypto: aspeed - Remove redundant dev_err call
Date: Fri, 30 Sep 2022 13:56:20 +0800 [thread overview]
Message-ID: <YzaFBPVtJT4hMCvw@gondor.apana.org.au> (raw)
In-Reply-To: <afde3f5c-32e4-6b89-8d6b-1f4f5a7744c4@huawei.com>
On Fri, Sep 23, 2022 at 08:26:21PM +0800, shangxiaojing wrote:
>
> On 2022/9/23 18:15, Neal Liu wrote:
> > > devm_ioremap_resource() prints error message in itself. Remove the dev_err
> > > call to avoid redundant error message.
> > >
> > > Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
> > > ---
> > > drivers/crypto/aspeed/aspeed-hace.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/crypto/aspeed/aspeed-hace.c
> > > b/drivers/crypto/aspeed/aspeed-hace.c
> > > index 3f880aafb6a2..e05c32c31842 100644
> > > --- a/drivers/crypto/aspeed/aspeed-hace.c
> > > +++ b/drivers/crypto/aspeed/aspeed-hace.c
> > > @@ -123,10 +123,8 @@ static int aspeed_hace_probe(struct platform_device
> > > *pdev)
> > > platform_set_drvdata(pdev, hace_dev);
> > >
> > > hace_dev->regs = devm_ioremap_resource(&pdev->dev, res);
> > > - if (IS_ERR(hace_dev->regs)) {
> > > - dev_err(&pdev->dev, "Failed to map resources\n");
> > > + if (IS_ERR(hace_dev->regs))
> > > return PTR_ERR(hace_dev->regs);
> > > - }
> > >
> > > /* Get irq number and register it */
> > > hace_dev->irq = platform_get_irq(pdev, 0);
> > > --
> > > 2.17.1
> > Similar patch just be proposed few days ago.
> > https://patchwork.kernel.org/project/linux-crypto/patch/20220920032118.6440-1-yuehaibing@huawei.com/
>
> sorry, pls ignore mine.
Actually I think these two patches are different and both can be
applied.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-09-30 5:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 10:01 [PATCH -next] crypto: aspeed - Remove redundant dev_err call Shang XiaoJing
2022-09-23 10:15 ` Neal Liu
2022-09-23 12:26 ` shangxiaojing
2022-09-30 5:56 ` Herbert Xu [this message]
2022-09-30 6:17 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzaFBPVtJT4hMCvw@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=andrew@aj.id.au \
--cc=davem@davemloft.net \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
--cc=shangxiaojing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).