From: Herbert Xu <herbert@gondor.apana.org.au>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
"meenakshi.aggarwal@nxp.com" <meenakshi.aggarwal@nxp.com>,
"horia.geanta@nxp.com" <horia.geanta@nxp.com>,
"V.sethi@nxp.com" <V.sethi@nxp.com>,
"pankaj.gupta@nxp.com" <pankaj.gupta@nxp.com>,
"gaurav.jain@nxp.com" <gaurav.jain@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iuliana.prodan@nxp.com" <iuliana.prodan@nxp.com>,
lucas.segarra.fernandez@intel.com
Subject: Re: [PATCH 0/5] Remove CRYPTO_ALG_ALLOCATES_MEMORY flag
Date: Fri, 9 Jun 2023 17:24:04 +0800 [thread overview]
Message-ID: <ZILvtASXQKLG43y9@gondor.apana.org.au> (raw)
In-Reply-To: <ZHh/zqNu7XzwJTl5@gcabiddu-mobl1.ger.corp.intel.com>
On Thu, Jun 01, 2023 at 12:23:58PM +0100, Giovanni Cabiddu wrote:
>
> BTW, some time ago we did an assessment of the users of
> !CRYPTO_ALG_ALLOCATES_MEMORY and we came to the conclusion that we
> cannot just update the documentation.
> dm-crypt uses scatterlists with at most 4 entries. dm-integrity,
> instead, might allocate memory for scatterlists with an arbitrary number
> of entries.
dm-integrity shouldn't be using ALLOCATES_MEMORY at all. It's
using GFP_KERNEL allocations right next to the crypto operations.
But those are some seriously big crypto operations, 16 thousand
4K pages in one hit?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-06-09 9:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 15:34 [PATCH 0/5] Remove CRYPTO_ALG_ALLOCATES_MEMORY flag meenakshi.aggarwal
2023-05-23 15:34 ` [PATCH 1/5] crypto:caam - avoid allocating memory at crypto request runtime for skcipher meenakshi.aggarwal
2023-05-23 15:34 ` [PATCH 2/5] crypto:caam - avoid allocating memory at crypto request runtime for aead meenakshi.aggarwal
2023-05-23 15:34 ` [PATCH 3/5] crypto: caam - avoid allocating memory at crypto request runtime for hash meenakshi.aggarwal
2023-05-23 15:34 ` [PATCH 4/5] crypto: caam/qi - avoid allocating memory at crypto request runtime meenakshi.aggarwal
2023-05-23 15:34 ` [PATCH 5/5] crypto: caam/qi2 " meenakshi.aggarwal
2023-05-23 16:55 ` [PATCH 0/5] Remove CRYPTO_ALG_ALLOCATES_MEMORY flag Eric Biggers
2023-05-26 6:10 ` Meenakshi Aggarwal
2023-06-01 10:33 ` Herbert Xu
2023-06-01 11:23 ` Giovanni Cabiddu
2023-06-09 9:24 ` Herbert Xu [this message]
2023-06-10 8:41 ` Giovanni Cabiddu
2023-06-14 6:21 ` Meenakshi Aggarwal
2023-06-14 9:48 ` Herbert Xu
2023-07-04 9:19 ` Meenakshi Aggarwal
2023-07-05 17:51 ` Giovanni Cabiddu
2023-07-06 5:05 ` Meenakshi Aggarwal
2023-06-08 11:45 ` Pankaj Gupta
2023-06-09 10:38 ` [PATCH v2 " meenakshi.aggarwal
2023-06-09 10:38 ` [PATCH v2 1/5] crypto:caam - avoid allocating memory at crypto request runtime for skcipher meenakshi.aggarwal
2023-06-10 2:18 ` Eric Biggers
2023-06-12 8:22 ` Meenakshi Aggarwal
2023-06-09 10:38 ` [PATCH v2 2/5] crypto:caam - avoid allocating memory at crypto request runtime for aead meenakshi.aggarwal
2023-06-09 10:38 ` [PATCH v2 3/5] crypto: caam - avoid allocating memory at crypto request runtime for hash meenakshi.aggarwal
2023-06-09 10:38 ` [PATCH v2 4/5] crypto: caam/qi - avoid allocating memory at crypto request runtime meenakshi.aggarwal
2023-06-09 10:38 ` [PATCH v2 5/5] crypto: caam/qi2 " meenakshi.aggarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZILvtASXQKLG43y9@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=V.sethi@nxp.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=gaurav.jain@nxp.com \
--cc=giovanni.cabiddu@intel.com \
--cc=horia.geanta@nxp.com \
--cc=iuliana.prodan@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.segarra.fernandez@intel.com \
--cc=meenakshi.aggarwal@nxp.com \
--cc=pankaj.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).