linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: rohit maheshwari <rohitm@chelsio.com>
To: YueHaibing <yuehaibing@huawei.com>,
	ayush.sawal@chelsio.com, vinay.yadav@chelsio.com,
	herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next] chcr: remove set but not used variable 'status'
Date: Sun, 15 Mar 2020 21:39:24 +0530	[thread overview]
Message-ID: <a3e5ad76-80c2-cef3-7de2-7495d2c15da5@chelsio.com> (raw)
In-Reply-To: <20200314105120.20968-1-yuehaibing@huawei.com>


On 14/03/20 4:21 PM, YueHaibing wrote:
> drivers/crypto/chelsio/chcr_ktls.c: In function chcr_ktls_cpl_set_tcb_rpl:
> drivers/crypto/chelsio/chcr_ktls.c:662:11: warning:
>   variable status set but not used [-Wunused-but-set-variable]
>
> commit 8a30923e1598 ("cxgb4/chcr: Save tx keys and handle HW response")
> involved this unused variable, remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   drivers/crypto/chelsio/chcr_ktls.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/chelsio/chcr_ktls.c b/drivers/crypto/chelsio/chcr_ktls.c
> index f0c3834eda4f..00099e793e63 100644
> --- a/drivers/crypto/chelsio/chcr_ktls.c
> +++ b/drivers/crypto/chelsio/chcr_ktls.c
> @@ -659,10 +659,9 @@ int chcr_ktls_cpl_set_tcb_rpl(struct adapter *adap, unsigned char *input)
>   	const struct cpl_set_tcb_rpl *p = (void *)input;
>   	struct chcr_ktls_info *tx_info = NULL;
>   	struct tid_info *t;
> -	u32 tid, status;
> +	u32 tid;
>   
>   	tid = GET_TID(p);
> -	status = p->status;
>   
>   	t = &adap->tids;
>   	tx_info = lookup_tid(t, tid);

Thanks for fixing it. Looks good to me.



  reply	other threads:[~2020-03-15 16:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-14 10:51 YueHaibing
2020-03-15 16:09 ` rohit maheshwari [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-03-14 10:19 YueHaibing
2020-03-14 10:49 ` Yuehaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3e5ad76-80c2-cef3-7de2-7495d2c15da5@chelsio.com \
    --to=rohitm@chelsio.com \
    --cc=ayush.sawal@chelsio.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vinay.yadav@chelsio.com \
    --cc=yuehaibing@huawei.com \
    --subject='Re: [PATCH net-next] chcr: remove set but not used variable '\''status'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).