From: Philipp Zabel <p.zabel@pengutronix.de>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
"Matt Mackall" <mpm@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Rob Herring" <robh+dt@kernel.org>,
"Nicolas Saenz Julienne" <nsaenzjulienne@suse.de>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Alexandru Ardelean" <alexandru.ardelean@analog.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Rikard Falkeborn" <rikard.falkeborn@gmail.com>,
"Stefan Wahren" <stefan.wahren@i2se.com>,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] hwrng: bcm2835: add reset support
Date: Thu, 04 Mar 2021 12:27:13 +0100 [thread overview]
Message-ID: <a9d636b617832f0c0dd86dd63c2a0ef913971d83.camel@pengutronix.de> (raw)
In-Reply-To: <20210304073308.25906-3-noltari@gmail.com>
On Thu, 2021-03-04 at 08:33 +0100, Álvaro Fernández Rojas wrote:
> BCM6368 devices need to reset the in order to generate true random numbers.
> This is what BCM6368 produces without a reset:
> root@OpenWrt:/# cat /dev/hwrng | rngtest -c 1000
> rngtest 6.10
> Copyright (c) 2004 by Henrique de Moraes Holschuh
> This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> rngtest: starting FIPS tests...
> rngtest: bits received from input: 20000032
> rngtest: FIPS 140-2 successes: 0
> rngtest: FIPS 140-2 failures: 1000
> rngtest: FIPS 140-2(2001-10-10) Monobit: 2
> rngtest: FIPS 140-2(2001-10-10) Poker: 1000
> rngtest: FIPS 140-2(2001-10-10) Runs: 1000
> rngtest: FIPS 140-2(2001-10-10) Long run: 30
> rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
> rngtest: input channel speed: (min=37.253; avg=320.827; max=635.783)Mibits/s
> rngtest: FIPS tests speed: (min=12.141; avg=15.034; max=16.428)Mibits/s
> rngtest: Program run time: 1336176 microseconds
> cat: write error: Broken pipe
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> v5: remove reset_control_rearm().
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
prev parent reply other threads:[~2021-03-04 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 7:33 [PATCH v5 0/2] hwrng: bcm2835: add reset support Álvaro Fernández Rojas
2021-03-04 7:33 ` [PATCH v5 1/2] dt-bindings: rng: bcm2835: document " Álvaro Fernández Rojas
2021-03-04 12:08 ` Nicolas Saenz Julienne
2021-03-04 20:47 ` Rob Herring
2021-03-04 7:33 ` [PATCH v5 2/2] hwrng: bcm2835: add " Álvaro Fernández Rojas
2021-03-04 11:27 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9d636b617832f0c0dd86dd63c2a0ef913971d83.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=alexandru.ardelean@analog.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=mpm@selenic.com \
--cc=narmstrong@baylibre.com \
--cc=noltari@gmail.com \
--cc=nsaenzjulienne@suse.de \
--cc=rikard.falkeborn@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).