From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3419FC32771 for ; Thu, 16 Jan 2020 00:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06DAC2084D for ; Thu, 16 Jan 2020 00:18:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lw2cBnfc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729327AbgAPASw (ORCPT ); Wed, 15 Jan 2020 19:18:52 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:54636 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726310AbgAPASw (ORCPT ); Wed, 15 Jan 2020 19:18:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L3ioD26th/wm3eYc9K20nMrNLwYjuFwfcgehlyvc/ZQ=; b=lw2cBnfcr+3/zPcRgsnl8XSH/ M9BdQMP/WUuSwuchi1Rzm6YnFogsDEV9PmMWTDjuslrYYQ1XjtTQS1/Ttr1/ZpyT3JWmEBmllBGVK x+zCeMSrKT31Fa1r/CccUbbcG9xYnYrBhUvaNY/UnYiM+YDgzqWI+d0wdWfutfxc7PY2czlbLUwi2 Kc9jTaP3y9hDIXCcQJ3INyMsadrR+mT6RPotuTDuv7NaCuXyWxV0PSkIjLs2HkGBaxdsIirDVaO9n Vi8CnsKp2OBGGGe3/4W3STsjrQnVnHGlNp9HSsuk1sh1JeLzUQ7SV6ixcC8PhV0pWxTZGJPCpvcbK aSKgBrVVg==; Received: from [2601:1c0:6280:3f0::ed68] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1irsrc-0003q7-KU; Thu, 16 Jan 2020 00:18:20 +0000 Subject: Re: [PATCH v28 11/12] LRNG - add interface for gathering of raw entropy To: =?UTF-8?Q?Stephan_M=c3=bcller?= , Arnd Bergmann Cc: Greg Kroah-Hartman , linux-crypto@vger.kernel.org, LKML , linux-api@vger.kernel.org, "Eric W. Biederman" , "Alexander E. Patrakov" , "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Willy Tarreau , Matthew Garrett , Vito Caputo , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , Andy Lutomirski , Florian Weimer , Lennart Poettering , Nicolai Stange , "Peter, Matthias" , Marcelo Henrique Cerri , Roman Drahtmueller , Neil Horman , Julia Lawall , Dan Carpenter References: <6157374.ptSnyUpaCn@positron.chronox.de> <2641155.iNH938UiKq@positron.chronox.de> <5951792.lmNsirYsPE@positron.chronox.de> <2048458.ADJAtTWDj8@positron.chronox.de> From: Randy Dunlap Message-ID: Date: Wed, 15 Jan 2020 16:18:18 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <2048458.ADJAtTWDj8@positron.chronox.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 1/15/20 2:35 AM, Stephan Müller wrote: > > CC: "Eric W. Biederman" > CC: "Alexander E. Patrakov" > CC: "Ahmed S. Darwish" > CC: "Theodore Y. Ts'o" > CC: Willy Tarreau > CC: Matthew Garrett > CC: Vito Caputo > CC: Andreas Dilger > CC: Jan Kara > CC: Ray Strode > CC: William Jon McCann > CC: zhangjs > CC: Andy Lutomirski > CC: Florian Weimer > CC: Lennart Poettering > CC: Nicolai Stange > Reviewed-by: Roman Drahtmueller > Tested-by: Roman Drahtmüller > Tested-by: Marcelo Henrique Cerri > Tested-by: Neil Horman > Signed-off-by: Stephan Mueller > --- > drivers/char/lrng/Kconfig | 16 ++ > drivers/char/lrng/Makefile | 1 + > drivers/char/lrng/lrng_testing.c | 271 +++++++++++++++++++++++++++++++ > 3 files changed, 288 insertions(+) > create mode 100644 drivers/char/lrng/lrng_testing.c > > diff --git a/drivers/char/lrng/lrng_testing.c b/drivers/char/lrng/lrng_testing.c > new file mode 100644 > index 000000000000..0e287eccd622 > --- /dev/null > +++ b/drivers/char/lrng/lrng_testing.c > @@ -0,0 +1,271 @@ > +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +/* > + * Linux Random Number Generator (LRNG) Raw entropy collection tool > + * > + * Copyright (C) 2019 - 2020, Stephan Mueller > + */ > + > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "lrng_internal.h" > + > +#define LRNG_TESTING_RINGBUFFER_SIZE 1024 > +#define LRNG_TESTING_RINGBUFFER_MASK (LRNG_TESTING_RINGBUFFER_SIZE - 1) > + > +static u32 lrng_testing_rb[LRNG_TESTING_RINGBUFFER_SIZE]; > +static u32 lrng_rb_reader = 0; > +static u32 lrng_rb_writer = 0; > +static atomic_t lrng_testing_enabled = ATOMIC_INIT(0); > + > +static DECLARE_WAIT_QUEUE_HEAD(lrng_raw_read_wait); > +static DEFINE_SPINLOCK(lrng_raw_lock); > + > +/* > + * 0 ==> No boot test, gathering of runtime data allowed > + * 1 ==> Boot test enabled and ready for collecting data, gathering runtime > + * data is disabled > + * 2 ==> Boot test completed and disabled, gathering of runtime data is > + * disabled > + */ > +static u32 boot_test = 0; > +module_param(boot_test, uint, 0644); > +MODULE_PARM_DESC(boot_test, "Enable gathering boot time entropy of the first" > + " entropy events"); One line for the string, please. -- ~Randy Reported-by: Randy Dunlap