linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	davem@davemloft.net, herbert@gondor.apana.org.au,
	khilman@baylibre.com, mark.rutland@arm.com, robh+dt@kernel.org,
	martin.blumenstingl@googlemail.com
Subject: [PATCH] crypto: amlogic: fix devm_platform_ioremap_resource.cocci warnings
Date: Tue, 15 Oct 2019 12:40:42 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1910151239360.2818@hadrien> (raw)

From: kbuild test robot <lkp@intel.com>

drivers/crypto/amlogic/amlogic-gxl-core.c:241:1-9: WARNING: Use devm_platform_ioremap_resource for mc -> base

 Use devm_platform_ioremap_resource helper which wraps
 platform_get_resource() and devm_ioremap_resource() together.

Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci

Fixes: 28b8a60c6c83 ("crypto: amlogic: Add crypto accelerator for amlogic GXL")
CC: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

url:    https://github.com/0day-ci/linux/commits/Corentin-Labbe/crypto-add-amlogic-crypto-offloader-driver/20191014-133654
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago

 amlogic-gxl-core.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -223,7 +223,6 @@ static void meson_unregister_algs(struct

 static int meson_crypto_probe(struct platform_device *pdev)
 {
-	struct resource *res;
 	struct meson_dev *mc;
 	int err, i;

@@ -237,8 +236,7 @@ static int meson_crypto_probe(struct pla
 	mc->dev = &pdev->dev;
 	platform_set_drvdata(pdev, mc);

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	mc->base = devm_ioremap_resource(&pdev->dev, res);
+	mc->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(mc->base)) {
 		err = PTR_ERR(mc->base);
 		dev_err(&pdev->dev, "Cannot request MMIO err=%d\n", err);

                 reply	other threads:[~2019-10-15 10:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1910151239360.2818@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=clabbe@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).