From: Christophe Leroy <christophe.leroy@c-s.fr>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: talitos - fix missing break in switch statement
Date: Tue, 10 Sep 2019 08:06:46 +0200 [thread overview]
Message-ID: <b2c4faf9-9b10-882d-57db-bcbc3ed2a025@c-s.fr> (raw)
In-Reply-To: <20190909052952.GA32131@embeddedor>
Le 09/09/2019 à 07:29, Gustavo A. R. Silva a écrit :
> Add missing break statement in order to prevent the code from falling
> through to case CRYPTO_ALG_TYPE_AHASH.
>
> Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
> Cc: stable@vger.kernel.org
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> drivers/crypto/talitos.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index c9d686a0e805..4818ae427098 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
> break;
> case CRYPTO_ALG_TYPE_AEAD:
> crypto_unregister_aead(&t_alg->algt.alg.aead);
> + break;
> case CRYPTO_ALG_TYPE_AHASH:
> crypto_unregister_ahash(&t_alg->algt.alg.hash);
> break;
>
next prev parent reply other threads:[~2019-09-10 6:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 5:29 [PATCH] crypto: talitos - fix missing break in switch statement Gustavo A. R. Silva
2019-09-10 6:06 ` Christophe Leroy [this message]
2019-09-20 14:53 ` Gustavo A. R. Silva
2019-09-20 12:59 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c4faf9-9b10-882d-57db-bcbc3ed2a025@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).