linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: yumeng <yumeng18@huawei.com>
Cc: linux-crypto@vger.kernel.org, xuzaibo@huawei.com,
	wangzhou1@hisilicon.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/5] crypto: hisilicon/hpre - add 'ECDH' algorithm
Date: Wed, 16 Dec 2020 21:10:15 +0100	[thread overview]
Message-ID: <b38e3b40ef198166bff193940b8c82c41db6f13c.camel@chronox.de> (raw)
In-Reply-To: <711de58c-4f7c-4643-4b8b-6af98ed1a7bc@huawei.com>

Am Mittwoch, dem 16.12.2020 um 10:39 +0800 schrieb yumeng:
> 
> 
> 
> > Am Freitag, den 11.12.2020, 14:30 +0800 schrieb Meng Yu:
> > > 
> > > +/* size in bytes of the n prime */
> > > +#define HPRE_ECC_NIST_P128_N_SIZE      16
> > 
> > Do we truly need P-128? Besides, I do not see that curve being defined in
> > contemporary cipher specs.
> > 
> > > +#define HPRE_ECC_NIST_P192_N_SIZE      24
> > > +#define HPRE_ECC_NIST_P224_N_SIZE      28
> > > +#define HPRE_ECC_NIST_P256_N_SIZE      32
> > > +#define HPRE_ECC_NIST_P320_N_SIZE      40
> > 
> > Do we truly need P-320? Besides, I do not see that curve being defined in
> > contemporary cipher specs.
> 
> Yes, in rfc 5903, only P-256, P-384 and P-521 is defined, but in
> 'rfc5639' and  "SEC 2: Recommended Elliptic Curve Domain Parameters",
> other curves like P-128, P-192, P-224, and P-320 curve parameters are
> found, and they are used in 'openssl';
> How about your idea?

Who is going to use that curve considering that common protocols that are
implemented in the kernel do not use it?

Thanks
Stephan


  reply	other threads:[~2020-12-16 20:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11  6:30 [PATCH v4 0/5] add ECDH and CURVE25519 algorithms support for Kunpeng 930 Meng Yu
2020-12-11  6:30 ` [PATCH v4 1/5] crypto: hisilicon/hpre - add some updates to adapt to " Meng Yu
2020-12-11  6:30 ` [PATCH v4 2/5] crypto: hisilicon/hpre - add algorithm type Meng Yu
2020-12-11  6:30 ` [PATCH v4 3/5] crypto: expose elliptic curve parameters as Crypto APIs Meng Yu
2020-12-11 13:13   ` Vitaly Chikunov
     [not found]     ` <75a25392-464d-b76e-ba92-4287e24acbf7@huawei.com>
2020-12-16  2:32       ` Fwd: " yumeng
2020-12-11  6:30 ` [PATCH v4 4/5] crypto: hisilicon/hpre - add 'ECDH' algorithm Meng Yu
2020-12-11 14:08   ` Stephan Mueller
     [not found]     ` <3903e2e8-165f-51b5-056c-24b8ce52e842@huawei.com>
2020-12-16  2:39       ` yumeng
2020-12-16 20:10         ` Stephan Mueller [this message]
2020-12-17  3:07           ` yumeng
2020-12-19 21:25             ` Stephan Müller
2020-12-11  6:30 ` [PATCH v4 5/5] crypto: hisilicon/hpre - add 'CURVE25519' algorithm Meng Yu
2020-12-11 14:14   ` Stephan Mueller
     [not found]     ` <e6bf72e0-38cd-a17e-ecae-e6fabdb313eb@huawei.com>
2020-12-16  2:45       ` yumeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b38e3b40ef198166bff193940b8c82c41db6f13c.camel@chronox.de \
    --to=smueller@chronox.de \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangzhou1@hisilicon.com \
    --cc=xuzaibo@huawei.com \
    --cc=yumeng18@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).