Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init
@ 2020-06-22 17:50 Markus Elfring
  2020-06-23 13:44 ` Maxime Ripard
  0 siblings, 1 reply; 7+ messages in thread
From: Markus Elfring @ 2020-06-22 17:50 UTC (permalink / raw)
  To: Dinghao Liu, linux-arm-kernel, linux-crypto
  Cc: Aditya Pakki, Navid Emamdoost, Kangjie Lu, Qiushi Wu,
	linux-kernel, YueHaibing, Maxime Ripard, Mauro Carvalho Chehab,
	Herbert Xu, Eric Biggers, David S. Miller, Corentin Labbe,
	Chen-Yu Tsai

> Fix this by …

Please replace the beginning of this sentence with the tag “Fixes”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183

Regards,
Markus

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init
  2020-06-22 17:50 [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init Markus Elfring
@ 2020-06-23 13:44 ` Maxime Ripard
  2020-06-23 15:00   ` Markus Elfring
  0 siblings, 1 reply; 7+ messages in thread
From: Maxime Ripard @ 2020-06-23 13:44 UTC (permalink / raw)
  To: Markus Elfring
  Cc: Dinghao Liu, linux-arm-kernel, linux-crypto, Aditya Pakki,
	Navid Emamdoost, Kangjie Lu, Qiushi Wu, linux-kernel, YueHaibing,
	Mauro Carvalho Chehab, Herbert Xu, Eric Biggers, David S. Miller,
	Corentin Labbe, Chen-Yu Tsai

On Mon, Jun 22, 2020 at 07:50:08PM +0200, Markus Elfring wrote:
> > Fix this by …
> 
> Please replace the beginning of this sentence with the tag “Fixes”.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183

No, not really. The comment you (partially) quoted explains how the
issue is fixed, your suggestion explains what commit introduced the fix
in the first place. They are both beneficial, but there's strictly no
reason to remove the former for the latter.

Maxime

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init
  2020-06-23 13:44 ` Maxime Ripard
@ 2020-06-23 15:00   ` Markus Elfring
  2020-06-23 16:56     ` Maxime Ripard
  0 siblings, 1 reply; 7+ messages in thread
From: Markus Elfring @ 2020-06-23 15:00 UTC (permalink / raw)
  To: Maxime Ripard, Dinghao Liu, linux-arm-kernel, linux-crypto
  Cc: Aditya Pakki, Navid Emamdoost, Kangjie Lu, Qiushi Wu,
	linux-kernel, YueHaibing, Mauro Carvalho Chehab, Herbert Xu,
	Eric Biggers, David S. Miller, Corentin Labbe, Chen-Yu Tsai

>>> Fix this by …
>>
>> Please replace the beginning of this sentence with the tag “Fixes”.
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
>
> No, not really. The comment you (partially) quoted explains how the
> issue is fixed, your suggestion explains what commit introduced the fix
> in the first place. They are both beneficial, but there's strictly no
> reason to remove the former for the latter.

Do you care to improve this change description another bit?

Regards,
Markus

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init
  2020-06-23 15:00   ` Markus Elfring
@ 2020-06-23 16:56     ` Maxime Ripard
  2020-06-23 18:12       ` Markus Elfring
  0 siblings, 1 reply; 7+ messages in thread
From: Maxime Ripard @ 2020-06-23 16:56 UTC (permalink / raw)
  To: Markus Elfring
  Cc: Dinghao Liu, linux-arm-kernel, linux-crypto, Aditya Pakki,
	Navid Emamdoost, Kangjie Lu, Qiushi Wu, linux-kernel, YueHaibing,
	Mauro Carvalho Chehab, Herbert Xu, Eric Biggers, David S. Miller,
	Corentin Labbe, Chen-Yu Tsai

On Tue, Jun 23, 2020 at 05:00:32PM +0200, Markus Elfring wrote:
> >>> Fix this by …
> >>
> >> Please replace the beginning of this sentence with the tag “Fixes”.
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
> >
> > No, not really. The comment you (partially) quoted explains how the
> > issue is fixed, your suggestion explains what commit introduced the fix
> > in the first place. They are both beneficial, but there's strictly no
> > reason to remove the former for the latter.
> 
> Do you care to improve this change description another bit?

I'm not sure which change description you're talking about?

Maxime

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init
  2020-06-23 16:56     ` Maxime Ripard
@ 2020-06-23 18:12       ` Markus Elfring
  0 siblings, 0 replies; 7+ messages in thread
From: Markus Elfring @ 2020-06-23 18:12 UTC (permalink / raw)
  To: Maxime Ripard, Dinghao Liu, linux-arm-kernel, linux-crypto
  Cc: Aditya Pakki, Navid Emamdoost, Kangjie Lu, Qiushi Wu,
	linux-kernel, YueHaibing, Mauro Carvalho Chehab, Herbert Xu,
	Eric Biggers, David S. Miller, Corentin Labbe, Chen-Yu Tsai

>>>>> Fix this by …
>>>>
>>>> Please replace the beginning of this sentence with the tag “Fixes”.
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
>>>
>>> No, not really. The comment you (partially) quoted explains how the
>>> issue is fixed, your suggestion explains what commit introduced the fix
>>> in the first place. They are both beneficial, but there's strictly no
>>> reason to remove the former for the latter.
>>
>> Do you care to improve this change description another bit?
>
> I'm not sure which change description you're talking about?

Repetition:
https://lore.kernel.org/patchwork/patch/1260551/
https://lore.kernel.org/linux-crypto/20200622024014.11347-1-dinghao.liu@zju.edu.cn/

pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a corresponding decrement is
needed on the error handling path to keep the counter balanced.

Fix this by adding the missed function call.



How do you think about to avoid a wording weakness there (for example)
besides other possible adjustments?

Regards,
Markus

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init
  2020-06-22  2:40 Dinghao Liu
@ 2020-07-03  4:47 ` Herbert Xu
  0 siblings, 0 replies; 7+ messages in thread
From: Herbert Xu @ 2020-07-03  4:47 UTC (permalink / raw)
  To: Dinghao Liu
  Cc: kjlu, Corentin Labbe, David S. Miller, Maxime Ripard,
	Chen-Yu Tsai, Mauro Carvalho Chehab, Eric Biggers, YueHaibing,
	linux-crypto, linux-arm-kernel, linux-kernel

On Mon, Jun 22, 2020 at 10:40:08AM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a corresponding decrement is
> needed on the error handling path to keep the counter balanced.
> 
> Fix this by adding the missed function call.
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
>  drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init
@ 2020-06-22  2:40 Dinghao Liu
  2020-07-03  4:47 ` Herbert Xu
  0 siblings, 1 reply; 7+ messages in thread
From: Dinghao Liu @ 2020-06-22  2:40 UTC (permalink / raw)
  To: dinghao.liu, kjlu
  Cc: Corentin Labbe, Herbert Xu, David S. Miller, Maxime Ripard,
	Chen-Yu Tsai, Mauro Carvalho Chehab, Eric Biggers, YueHaibing,
	linux-crypto, linux-arm-kernel, linux-kernel

pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a corresponding decrement is
needed on the error handling path to keep the counter balanced.

Fix this by adding the missed function call.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
index a6abb701bfc6..3665a0a2038f 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
@@ -358,6 +358,7 @@ int sun8i_ce_cipher_init(struct crypto_tfm *tfm)
 
 	return 0;
 error_pm:
+	pm_runtime_put_noidle(op->ce->dev);
 	crypto_free_sync_skcipher(op->fallback_tfm);
 	return err;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 17:50 [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init Markus Elfring
2020-06-23 13:44 ` Maxime Ripard
2020-06-23 15:00   ` Markus Elfring
2020-06-23 16:56     ` Maxime Ripard
2020-06-23 18:12       ` Markus Elfring
  -- strict thread matches above, loose matches on Subject: below --
2020-06-22  2:40 Dinghao Liu
2020-07-03  4:47 ` Herbert Xu

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git