From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4C1FC433DF for ; Tue, 18 Aug 2020 14:17:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F4EF20786 for ; Tue, 18 Aug 2020 14:17:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="AddjnMMA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726905AbgHRORl (ORCPT ); Tue, 18 Aug 2020 10:17:41 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:38644 "EHLO mail3.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726727AbgHRORh (ORCPT ); Tue, 18 Aug 2020 10:17:37 -0400 Received: from [192.168.254.6] (unknown [50.34.202.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id CEE1713C2B0; Tue, 18 Aug 2020 07:17:35 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com CEE1713C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1597760257; bh=KIzHoTBPXScNDkgRBTc//Tk16Di90O2SsNKgcbkuZ1U=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=AddjnMMAxZ4vFknsl9XObrE7Crma/60tHxNqctl22V1inhwUXWI/OIoepriL39C+p NLoKuL/Gdj7ewEp526iXfngfZ87HmvGzpv9Sj0QGR+N47E5O40HQwQO2F7S9phB5Pj hXlqMlydf7Wfx+bIslG/Hq1XOz4UVMx+Ej2ujDSI= Subject: Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher To: Herbert Xu Cc: Ard Biesheuvel , Linux Crypto Mailing List , Eric Biggers References: <20200802090616.1328-1-ardb@kernel.org> <20200818082410.GA24497@gondor.apana.org.au> <20200818135128.GA25652@gondor.apana.org.au> <2aad9569-877e-4398-88ef-e40d9bbf7656@candelatech.com> <20200818140532.GA25807@gondor.apana.org.au> From: Ben Greear Organization: Candela Technologies Message-ID: Date: Tue, 18 Aug 2020 07:17:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200818140532.GA25807@gondor.apana.org.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 8/18/20 7:05 AM, Herbert Xu wrote: > On Tue, Aug 18, 2020 at 06:56:12AM -0700, Ben Greear wrote: >> >> Herbert, thanks for working on this. If I apply the patches you posted, >> that is expected to provide wifi aes decryption speedup similar to what >> the original patch I sent does? Or, are additional patches needed? > > It depends on whether the wifi code uses the async ahash interface, > if not it probably won't make much of an impact at all. > > I just checked and if the code you're using is net/mac80211/aes_cmac.c > then it's using shash so it won't really benefit from this. However, > there's no reason why mac80211 can't be converted over to async as > we did for IPsec. I think converting it to async is beyond what I have time to work on and not sure if it would be accepted upstream anyway. Is there any easy way to use your work to make shash fast for aesni? I basically just want it to perform as well as it used to with my patch. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com