From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E4ECA9EBC for ; Fri, 25 Oct 2019 11:56:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22A9D21D71 for ; Fri, 25 Oct 2019 11:56:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="FPjQoP3G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393553AbfJYL4c (ORCPT ); Fri, 25 Oct 2019 07:56:32 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:44246 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726484AbfJYL4c (ORCPT ); Fri, 25 Oct 2019 07:56:32 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x9PBuPLf019737; Fri, 25 Oct 2019 06:56:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1572004585; bh=Zxenn+fmpG460N0SqQ6Tu2DGbjwSZ0VroN2GIMrsIAg=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=FPjQoP3Gpowa+D6OvDKpQbasvPFIDx4yo099WeqIeZ0WKN9yqa4PSc7BC8wEltjLF zaVujvZLSON4OAQRS+azkOxq3K5lAbTpIdeEcS9OWVRv/AxMLf3Wcbsw+CGm1t69CX 2At3aK98Lb/ZhWsMZUx8NVIxIRwYnsMWnRcngtxU= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x9PBuPkM117460 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 25 Oct 2019 06:56:25 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 25 Oct 2019 06:56:14 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 25 Oct 2019 06:56:24 -0500 Received: from [127.0.0.1] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x9PBuM2V019986; Fri, 25 Oct 2019 06:56:22 -0500 Subject: Re: [PATCH 00/10] crypto: omap fixes towards 5.5 From: Tero Kristo To: Ard Biesheuvel CC: Herbert Xu , "David S. Miller" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , , linux-arm-kernel References: <20191017122549.4634-1-t-kristo@ti.com> <8f97d690-a88a-55cb-eb67-206e01873d94@ti.com> Message-ID: Date: Fri, 25 Oct 2019 14:56:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <8f97d690-a88a-55cb-eb67-206e01873d94@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 25/10/2019 14:55, Tero Kristo wrote: > On 25/10/2019 14:33, Ard Biesheuvel wrote: >> On Thu, 17 Oct 2019 at 14:26, Tero Kristo wrote: >>> >>> Hi, >>> >>> This series fixes a number of bugs with omap crypto implementation. >>> These have become evident with the changes to the cryptomanager, where >>> it adds some new test cases and modifies some existing, namely the split >>> update tests. Also, while fixing the cryptomanager induced bugs, some >>> other surfaced with tcrypt/IPSec tests, so fixed them aswell. >>> >>> Patch #9 is against crypto core modifying the crypto_wait_req >>> common API to have a timeout for it also, currently it waits forever >>> and it is kind of difficult to see what test fails with crypto manager. >>> This is not really needed for anything, but it is kind of nice to have >>> (makes debugging easier.) >>> >>> This series has been tested on top of 5.4-rc2, with following setups, >>> on AM57xx-beagle-x15 board: >>> >>> - crypto manager self tests >>> - tcrypt performance test >>> - ipsec test with strongswan >>> >>> This series depends on the skcipher API switch patch from Ard Biesheuvel >>> [1]. >>> >> >> Hi Tero, >> >> On my BeagleBone White, I am hitting the following issues after >> applying these patches: >> >> [    7.493903] alg: skcipher: ecb-aes-omap encryption unexpectedly >> succeeded on test vector "random: len=531 klen=32"; >> expected_error=-22, cfg="random: inplace may_sleep use_finup >> src_divs=[44.72%@+4028, 14.70%@alignmask+3, 19.45%@+4070, >> 21.13%@+2728]" >> [    7.651103] alg: skcipher: cbc-aes-omap encryption unexpectedly >> succeeded on test vector "random: len=1118 klen=32"; >> expected_error=-22, cfg="random: may_sleep use_final >> src_divs=[41.87%@+31, 58.13%@+2510]" >> >> These are simply a result of the ECB and CBC implementations not >> returning -EINVAL when the input is not a multiple of the block size. >> >> [    7.845527] alg: skcipher: blocksize for ctr-aes-omap (16) doesn't >> match generic impl (1) >> >> This means cra_blocksize is not set to 1 as it should. If your driver >> uses the skcipher walk API, it should set the walksize to >> AES_BLOCK_SIZE to ensure that the input is handled correctly. If you >> don't, then you can disregard that part. >> >> [    8.306491] alg: aead: gcm-aes-omap setauthsize unexpectedly >> succeeded on test vector "random: alen=3 plen=31 authsize=6 klen=9"; >> expected_error=-22 >> >> Another missing sanity check. GCM only permits certain authsizes. >> >> [    9.074703] omap_crypto_copy_sgs: Couldn't allocate pages for >> unaligned cases. >> >> This is not a bug, but I'm not sure if the below is related or not. >> >> I'll preserve the binaries, in case you need me to objdump anything. > > What are these tests you are executing? For me, the testmgr self test > suite is passing just fine. Any extra tests you have enabled somehow? > > I am also running full test on different board though (am57xx), I > haven't been explicitly running anything on am335x. Oh, and btw, did you try without my series? I think the selftests are failing rather miserably without them... -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki