linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kim, David" <david.kim@ncipher.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	Greg KH <gregkh@linuxfoundation.org>
Cc: "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"Magee, Tim" <tim.magee@ncipher.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: RE: nCipher HSM kernel driver submission feedback request
Date: Mon, 23 Mar 2020 13:32:06 +0000	[thread overview]
Message-ID: <c34d5419ad38444d951f7cbb29b5c7ae@exukdagfar01.INTERNAL.ROOT.TES> (raw)
In-Reply-To: <9644fcdd-1453-616a-f607-4a1f39f433ff@zx2c4.com>

Hi Jason,

Thanks for your reply and helpful summary of the current discussion.

>
> It looks like this is some sort of PCIe HSM device. As far as I know, Linux
> doesn't have a standardized API for HSM devices (somebody correct me if
> I'm wrong), and probably that doesn't quite make sense, either, seeing as
> most HSMs are accessed anyway through userspace "drivers" -- that is, via
> libusb or over some networking protocol, or something else.
> Your situation is different in that it uses PCIe, so you need some kernel
> mediation in order to give access to your userspace components.
> And, different manufacturers' HSMs expose very different pieces of
> functionality, and I'm not sure a unified API for them would even make
> sense.

Yes, that's correct. There are currently no standardised APIs for HSM devices in
Linux and our PCIe device needs the kernel to facilitate operation.

>
> It looks like this driver exposes some device file, with a few IOCTLs and then
> support for reading and writing from and to the device. Besides some driver
> control things, what actually goes into the device -- that is, the protocol one
> must use to talk to the thing -- isn't actually described by the driver. You're
> just shuffling bytes in and out with some mediation around that.
>
> Can you confirm to me whether or not the above is accurate?

Yes, this is accurate.

>
> If so, then I'm not sure this belongs in the purview of the crypto list or has
> anything much to do with Linux crypto. This is a PCIe driver for some
> hardware that userspace has to talk to in order to do some stuff with it.

Again, you are correct. Although it is cryptographic hardware, the driver code
does not do anything cryptographic. It is just a PCIe driver.

>
> However, there's something else that you wrote that might make people
> less inclined to merge this:
>
>  > Our driver code is just a tube between proprietary code on the host
> machine and proprietary code on the HSM.
>
> It sounds like you need the kernel to expose your PCIe device in a way
> userspace can access, so that you can talk to it using proprietary code.
> In other words, this is a kernel driver that exists only to support closed source
> components. I have no idea about "official policy" on this matter, but I could
> imagine some people howling about it. On the other hand, the driver _is_
> doing something, and it seems like your hardware is somewhat complicated
> to interface with, and who wouldn't want an open source driver for that,
> even if it's just the low-level kernel/PCIe components?

Yes, we expect there to be some discussion about the driver being useful in the
kernel but need to resolve this discussion regarding the Linux crypto API first.

>
> Anyway, if my suppositions above are indeed correct, I'd encourage you to
> submit your driver to whoever maintains drivers/misc/ (Greg and Arnd, IIRC),
> and ignore the fact that your hardware has something to do with
> cryptography (though little to do with the Linux crypto API's range of
> responsibilities).

Yes, we submitted our driver code to Greg and drivers/misc but he requested
feedback from the crypto maintainers regarding potential changes to the Linux
crypto API. We do not intend to target our driver submission to drivers/crypto and
aren't using any of the Linux crypto APIs.

Regards,
Dave


David Kim
Senior Software Engineer
Tel: +44 1223 703449

nCipher Security
One Station Square
Cambridge CB1 2GA
United Kingdom


  reply	other threads:[~2020-03-23 13:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13  9:48 Kim, David
2020-03-13 10:09 ` Greg KH
2020-03-16 10:44   ` Kim, David
2020-03-16 11:23     ` Greg KH
2020-03-23  6:49 ` Jason A. Donenfeld
2020-03-23 13:32   ` Kim, David [this message]
2020-03-23 13:59     ` Greg KH
2020-04-17 15:12       ` Kim, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c34d5419ad38444d951f7cbb29b5c7ae@exukdagfar01.INTERNAL.ROOT.TES \
    --to=david.kim@ncipher.com \
    --cc=Jason@zx2c4.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=tim.magee@ncipher.com \
    --subject='RE: nCipher HSM kernel driver submission feedback request' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).