From: "Horia Geantă" <horia.geanta@nxp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"Andrei Botila (OSS)" <andrei.botila@oss.nxp.com>
Cc: Aymen Sghaier <aymen.sghaier@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH RESEND 1/9] crypto: caam/jr - add fallback for XTS with more than 8B IV
Date: Tue, 8 Sep 2020 13:35:04 +0300 [thread overview]
Message-ID: <c360d691-8253-bd99-af92-83d9f8e86a2d@nxp.com> (raw)
In-Reply-To: <20200821034651.GA25442@gondor.apana.org.au>
On 8/21/2020 6:47 AM, Herbert Xu wrote:
> On Thu, Aug 06, 2020 at 07:35:43PM +0300, Andrei Botila wrote:
>>
>> +static bool xts_skcipher_ivsize(struct skcipher_request *req)
>> +{
>> + struct crypto_skcipher *skcipher = crypto_skcipher_reqtfm(req);
>> + unsigned int ivsize = crypto_skcipher_ivsize(skcipher);
>> + u64 size = 0;
>> +
>> + if (IS_ALIGNED((unsigned long)req->iv, __alignof__(u64)))
>> + size = *(u64 *)(req->iv + (ivsize / 2));
>> + else
>> + size = get_unaligned((u64 *)(req->iv + (ivsize / 2)));
>> +
>> + return !!size;
>> +}
>
> Just go with the get_unaligned unconditionally.
>
Won't this lead to sub-optimal code for ARMv7
in case the IV is aligned?
Thanks,
Horia
next prev parent reply other threads:[~2020-09-08 10:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 16:35 [PATCH RESEND 0/9] crypto: caam - xts(aes) updates Andrei Botila
2020-08-06 16:35 ` [PATCH RESEND 1/9] crypto: caam/jr - add fallback for XTS with more than 8B IV Andrei Botila
2020-08-11 14:30 ` Horia Geantă
2020-08-21 3:47 ` Herbert Xu
2020-08-21 12:02 ` Horia Geantă
2020-08-19 23:56 ` Sasha Levin
2020-08-21 3:46 ` Herbert Xu
2020-09-08 10:35 ` Horia Geantă [this message]
2020-09-08 22:10 ` Herbert Xu
2020-09-14 16:23 ` Horia Geantă
2020-09-14 16:28 ` Ard Biesheuvel
2020-09-14 17:12 ` Horia Geantă
2020-09-14 18:20 ` Ard Biesheuvel
2020-09-15 10:02 ` Horia Geantă
2020-09-15 10:26 ` Ard Biesheuvel
2020-09-15 12:44 ` Horia Geantă
2020-09-15 12:51 ` Ard Biesheuvel
2020-08-06 16:35 ` [PATCH RESEND 2/9] crypto: caam/qi " Andrei Botila
2020-08-19 23:56 ` Sasha Levin
2020-08-06 16:35 ` [PATCH RESEND 3/9] crypto: caam/qi2 " Andrei Botila
2020-08-19 23:56 ` Sasha Levin
2020-08-06 16:35 ` [PATCH RESEND 4/9] crypto: caam/jr - add support for more XTS key lengths Andrei Botila
2020-08-11 14:36 ` Horia Geantă
2020-08-19 23:56 ` Sasha Levin
2020-08-06 16:35 ` [PATCH RESEND 5/9] crypto: caam/qi " Andrei Botila
2020-08-19 23:56 ` Sasha Levin
2020-08-06 16:35 ` [PATCH RESEND 6/9] crypto: caam/qi2 " Andrei Botila
2020-08-19 23:56 ` Sasha Levin
2020-08-06 16:35 ` [PATCH RESEND 7/9] crypto: caam/jr - add support for XTS with 16B IV Andrei Botila
2020-08-06 16:35 ` [PATCH RESEND 8/9] crypto: caam/qi " Andrei Botila
2020-08-06 16:35 ` [PATCH RESEND 9/9] crypto: caam/qi2 " Andrei Botila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c360d691-8253-bd99-af92-83d9f8e86a2d@nxp.com \
--to=horia.geanta@nxp.com \
--cc=andrei.botila@oss.nxp.com \
--cc=ardb@kernel.org \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).