From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB14C433FE for ; Sat, 25 Sep 2021 01:57:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51A6D610CF for ; Sat, 25 Sep 2021 01:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234271AbhIYB65 (ORCPT ); Fri, 24 Sep 2021 21:58:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232003AbhIYB64 (ORCPT ); Fri, 24 Sep 2021 21:58:56 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4590C061571; Fri, 24 Sep 2021 18:57:22 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id l16-20020a9d6a90000000b0053b71f7dc83so15648675otq.7; Fri, 24 Sep 2021 18:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3oB2P8meLlVrfmIZtbndjTCD4KmuRTjJ2hmbKASMUB4=; b=IrZ6ZJ8b4KRP8xmtLbLY46XPCf+70+su1EP90eoGPivamJ3Trkj1Q7ybYOyYta49Z4 15aup9LXk+auWBKHbDsbGEhNZIJ2Zbmv6F3qqsDpny+8Cq/n/XuZ1IpnWv9Xvors1GOh KwMn3awb5zk73nClanSTy1iPo2WSk+hDkPkLFuDF+ZZHKYfFYuokOLcwXUzlR+Lw7iMr O5L8NZ1Kxyzh4w2k/80AgfWIx2mmgyX2WZfM7NvCn+s0fs31GV6bOe7taerIMY9yv/uD +FeGOA7/EQJ2h+yOtJefjtFxZkgvofccPF+1GhuDbGhepZ8NOYy9ROou4FszVRrNzPYi wAOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3oB2P8meLlVrfmIZtbndjTCD4KmuRTjJ2hmbKASMUB4=; b=mNqgaqcignJ8OhkFC5/x3L+OB8DNlvhSF+EgG9DSeQ/1quktJ1WpJnv+i7Pc3uJ3Ct KIRtiYhxwEq2DUnv5SnfM6joKJ6x9H5wJW7b3gamroKBhyL1IuHhSg+DeZcSWXONvP1D W6Rw1CdkWyRUKBNKviCZb9KQkcLWhY8VC5n6WF11m1hZq/0L7wfNB2VPscSZ4P2isqaA BQQTe51n09LboQczU5bECcw+cFYiSSyh7AO15yGxOE34o+amyyiVWXyKTiK8Yrp/Kt6A tm0n876mghLuZD2UFYgKtizFqeZjBiROVIUG/RN6D1CgrtqKa6n0tF6cZG7mY0RZdFM4 Ckrw== X-Gm-Message-State: AOAM5314B1aOjtdWCU3zZu5EfXshrwSFGGWPQFblgJZJmPJDvZFiEg7I B+XYCF8oyEm4mqQjwWHErz9fSq86btT5aQ== X-Google-Smtp-Source: ABdhPJzw5hs8Plmcg4aKEYpIFApUbHYCJtvJA92CU50L7sFHWekBiFKdIJL4kbqfIBfm2rmUhfcUkw== X-Received: by 2002:a9d:7cd3:: with SMTP id r19mr1316974otn.214.1632535041879; Fri, 24 Sep 2021 18:57:21 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([8.48.134.50]) by smtp.googlemail.com with ESMTPSA id b4sm1449396ooi.17.2021.09.24.18.57.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Sep 2021 18:57:21 -0700 (PDT) Subject: Re: [PATCH 08/19] tcp: authopt: Disable via sysctl by default To: Leonard Crestez , Dmitry Safonov <0x7f454c46@gmail.com>, David Ahern , Shuah Khan Cc: Eric Dumazet , "David S. Miller" , Herbert Xu , Kuniyuki Iwashima , Hideaki YOSHIFUJI , Jakub Kicinski , Yuchung Cheng , Francesco Ruggeri , Mat Martineau , Christoph Paasch , Ivan Delalande , Priyaranjan Jha , Menglong Dong , netdev@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: From: David Ahern Message-ID: Date: Fri, 24 Sep 2021 19:57:19 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 9/21/21 10:14 AM, Leonard Crestez wrote: > This is mainly intended to protect against local privilege escalations > through a rarely used feature so it is deliberately not namespaced. > > Enforcement is only at the setsockopt level, this should be enough to > ensure that the tcp_authopt_needed static key never turns on. > > No effort is made to handle disabling when the feature is already in > use. > MD5 does not require a sysctl to use it, so why should this auth mechanism?