linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J, KEERTHY" <j-keerthy@ti.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	David Miller <davem@davemloft.net>
Cc: Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH -next] crypto: sa2ul: add Kconfig selects to fix build error
Date: Thu, 6 Aug 2020 23:07:56 +0530	[thread overview]
Message-ID: <ce215b73-4c76-648f-f19d-46930e73a5ed@ti.com> (raw)
In-Reply-To: <6e04b405-7369-ff04-a2dd-aa7c561e13d6@infradead.org>



On 8/6/2020 9:24 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> sa2ul.c uses sha{1,256,512}_zero_message_hash, so select the
> Kconfig symbols that provide those, like other crypto drivers do.
> 
> Fixes this build error:
> 
> ld: drivers/crypto/sa2ul.o: in function `sa_sha_digest':
> sa2ul.c:(.text+0x2b25): undefined reference to `sha512_zero_message_hash'

Thanks for catching this.

Reviewed-by: Keerthy <j-keerthy@ti.com>

> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Randy Dunlap <rdunlap@infradead.org> # 2020-07-29
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Keerthy <j-keerthy@ti.com>
> ---
>   drivers/crypto/Kconfig |    3 +++
>   1 file changed, 3 insertions(+)
> 
> --- linux-next-20200806.orig/drivers/crypto/Kconfig
> +++ linux-next-20200806/drivers/crypto/Kconfig
> @@ -873,6 +873,9 @@ config CRYPTO_DEV_SA2UL
>   	select CRYPTO_AES
>   	select CRYPTO_AES_ARM64
>   	select CRYPTO_ALGAPI
> +	select CRYPTO_SHA1
> +	select CRYPTO_SHA256
> +	select CRYPTO_SHA512
>   	select HW_RANDOM
>   	select SG_SPLIT
>   	help
> 

  reply	other threads:[~2020-08-06 17:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06 15:54 [PATCH -next] crypto: sa2ul: add Kconfig selects to fix build error Randy Dunlap
2020-08-06 17:37 ` J, KEERTHY [this message]
2020-08-21  7:57 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce215b73-4c76-648f-f19d-46930e73a5ed@ti.com \
    --to=j-keerthy@ti.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).