From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77266C43462 for ; Mon, 19 Apr 2021 11:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EE3161284 for ; Mon, 19 Apr 2021 11:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238606AbhDSLvD (ORCPT ); Mon, 19 Apr 2021 07:51:03 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:17015 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238929AbhDSLu7 (ORCPT ); Mon, 19 Apr 2021 07:50:59 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FP4mv4Lv5zPs8N; Mon, 19 Apr 2021 19:47:27 +0800 (CST) Received: from [10.67.101.248] (10.67.101.248) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Mon, 19 Apr 2021 19:50:17 +0800 Subject: Re: [PATCH] crypto: hisilicon/hpre - fix unmapping invalid dma address To: Herbert Xu References: <1618048157-6289-1-git-send-email-tanghui20@huawei.com> <20210416112638.GA14703@gondor.apana.org.au> CC: , , , , From: Hui Tang Message-ID: Date: Mon, 19 Apr 2021 19:50:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20210416112638.GA14703@gondor.apana.org.au> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.101.248] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 2021/4/16 19:26, Herbert Xu wrote: > On Sat, Apr 10, 2021 at 05:49:17PM +0800, Hui Tang wrote: >> Currently, an invalid dma address may be unmapped when calling >> 'xx_data_clr_all' in error path, so check dma address of sqe in/out >> whether it has been mapped before calling 'dma_free_coherent' or >> 'dma_unmap_single'. >> >> An abnormal case is as follows: >> hpre_curve25519_compute_value >> -> hpre_curve25519_src_init >> -> hpre_curve25519_hw_data_clr_all >> >> Fixes: a9214b0b6ed2(crypto: hisilicon - fix the check on dma address) >> Signed-off-by: Hui Tang >> --- >> drivers/crypto/hisilicon/hpre/hpre_crypto.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) > > This triggers new sparse warnings. Thanks, I will fix it in 5.13 rc1.