From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Gonglei <arei.gonglei@huawei.com>,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
virtio-dev@lists.oasis-open.org,
virtualization@lists.linux-foundation.org,
linux-crypto@vger.kernel.org
Cc: xuquan8@huawei.com, weidong.huang@huawei.com,
herbert@gondor.apana.org.au, hanweidong@huawei.com,
claudio.fontana@huawei.com, mst@redhat.com,
luonengjun@huawei.com, wanzongshun@huawei.com,
stefanha@redhat.com, jianjay.zhou@huawei.com,
longpeng2@huawei.com, davem@davemloft.net, wu.wubin@huawei.com,
arei.gonglei@hotmail.com
Subject: Re: [PATCH v8 1/1] crypto: add virtio-crypto driver
Date: Tue, 10 Jan 2017 13:27:04 +0100 [thread overview]
Message-ID: <e235caf4-f51c-dccf-4eb7-548d3fa71644@de.ibm.com> (raw)
In-Reply-To: <1481767396-187748-2-git-send-email-arei.gonglei@huawei.com>
On 12/15/2016 03:03 AM, Gonglei wrote:
[...]
> +
> +static struct crypto_alg virtio_crypto_algs[] = { {
> + .cra_name = "cbc(aes)",
> + .cra_driver_name = "virtio_crypto_aes_cbc",
> + .cra_priority = 501,
This is still higher than the hardware-accelerators (like intel aesni or the
s390 cpacf functions or the arm hw). aesni and s390/cpacf are supported by the
hardware virtualization and available to the guests. I do not see a way how virtio
crypto can be faster than that (in the end it might be cpacf/aesni + overhead)
instead it will very likely be slower.
So we should use a number that is higher than software implementations but
lower than the hw ones.
Just grepping around, the software ones seem be be around 100 and the hardware
ones around 200-400. So why was 150 not enough?
Christian
next prev parent reply other threads:[~2017-01-10 12:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 2:03 [PATCH v8 0/1] virtio-crypto: add Linux driver Gonglei
2016-12-15 2:03 ` [PATCH v8 1/1] crypto: add virtio-crypto driver Gonglei
2017-01-10 12:27 ` Christian Borntraeger [this message]
2017-01-10 12:36 ` Gonglei (Arei)
2017-01-10 12:56 ` Christian Borntraeger
2017-01-12 14:10 ` Christian Borntraeger
2017-01-12 14:23 ` Michael S. Tsirkin
2017-01-13 1:56 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e235caf4-f51c-dccf-4eb7-548d3fa71644@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=arei.gonglei@hotmail.com \
--cc=arei.gonglei@huawei.com \
--cc=claudio.fontana@huawei.com \
--cc=davem@davemloft.net \
--cc=hanweidong@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=jianjay.zhou@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=luonengjun@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wanzongshun@huawei.com \
--cc=weidong.huang@huawei.com \
--cc=wu.wubin@huawei.com \
--cc=xuquan8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).