From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44BFFC432C0 for ; Tue, 19 Nov 2019 17:18:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F04C22362 for ; Tue, 19 Nov 2019 17:18:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Xhk2Ba4R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727822AbfKSRSi (ORCPT ); Tue, 19 Nov 2019 12:18:38 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:38746 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727805AbfKSRSi (ORCPT ); Tue, 19 Nov 2019 12:18:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aYmtuEFF+xOPB8Y3q63c5aivou+rssRsl1ZruqJR3YQ=; b=Xhk2Ba4RE5sQp6Xhrisp9yAdb a6kScEfJGorN4s9IyqONGBGD5r+WATKiUvRdIQnzS4br3J7RnbMIEnrmIoCld00T/GpT5aE+5LiR/ OF0sbcikg0yYYpSsoFudFBK83cuHjU1DclZiT5VgYYIZjvaVzDFWAYZM2kUJwu8RVQBZ49L/gAe/2 3DDhaEO00s4S+UoRQUxXfGpNwb1jdI/bH94DFda+jGmReOHtsJZCUs8Q9d1GofxsE7vY2xNFWLj2K 7wEQzVjFDeoSY8altim3LTauF4vMSWHneoYWT9269fKCOZXOjCWjWBkuJwLNcFoNs3TUW6rBFrxA0 Tc7YVGxBw==; Received: from [2601:1c0:6280:3f0::5a22] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iX78X-0002YZ-J1; Tue, 19 Nov 2019 17:17:57 +0000 Subject: Re: [PATCH v25 12/12] LRNG - add interface for gathering of raw entropy To: =?UTF-8?Q?Stephan_M=c3=bcller?= , Arnd Bergmann Cc: Greg Kroah-Hartman , linux-crypto@vger.kernel.org, LKML , linux-api@vger.kernel.org, "Eric W. Biederman" , "Alexander E. Patrakov" , "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Willy Tarreau , Matthew Garrett , Vito Caputo , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , Andy Lutomirski , Florian Weimer , Lennart Poettering , Nicolai Stange , "Peter, Matthias" , Marcelo Henrique Cerri , Roman Drahtmueller , Neil Horman References: <6157374.ptSnyUpaCn@positron.chronox.de> <2787174.DQlWHN5GGo@positron.chronox.de> <3610406.x8mDjznOIz@positron.chronox.de> From: Randy Dunlap Message-ID: Date: Tue, 19 Nov 2019 09:17:55 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <3610406.x8mDjznOIz@positron.chronox.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi, On 11/16/19 1:38 AM, Stephan Müller wrote: > diff --git a/drivers/char/lrng/Kconfig b/drivers/char/lrng/Kconfig > index e6ca3acc1e48..4ccc710832ef 100644 > --- a/drivers/char/lrng/Kconfig > +++ b/drivers/char/lrng/Kconfig > @@ -169,4 +169,20 @@ config LRNG_APT_CUTOFF > default 325 if !LRNG_APT_BROKEN > default 32 if LRNG_APT_BROKEN > > +config LRNG_TESTING > + bool "Enable entropy test interface to LRNG noise source" > + select CONFIG_DEBUG_FS That should be spelled as DEBUG_FS and preferably would be "depends on" instead of 'select'. > + help > + The test interface allows a privileged process to capture > + the raw unconditioned noise that is collected by the LRNG > + for statistical analysis. Extracted noise data is not used > + to seed the LRNG. > + > + The raw noise data can be obtained using the lrng_raw > + debugfs file. Using the option lrng_testing.boot_test=1 > + the raw noise of the first 1000 entropy events since boot > + can be sampled. > + > + If unsure, say N. > + > endif # LRNG thanks. -- ~Randy