From: rohit maheshwari <rohitm@chelsio.com>
To: YueHaibing <yuehaibing@huawei.com>,
Ayush Sawal <ayush.sawal@chelsio.com>,
Vinay Kumar Yadav <vinay.yadav@chelsio.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] crypto: chelsio - remove set but not used variable 'adap'
Date: Sun, 15 Mar 2020 21:40:45 +0530 [thread overview]
Message-ID: <fcf6f896-8d60-836c-cdad-b5ca9c95b562@chelsio.com> (raw)
In-Reply-To: <20200314104441.79953-1-yuehaibing@huawei.com>
On 14/03/20 4:14 PM, YueHaibing wrote:
> drivers/crypto/chelsio/chcr_algo.c: In function 'chcr_device_init':
> drivers/crypto/chelsio/chcr_algo.c:1440:18: warning:
> variable 'adap' set but not used [-Wunused-but-set-variable]
>
> commit 567be3a5d227 ("crypto: chelsio - Use multiple txq/rxq per tfm
> to process the requests") involved this unused variable.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/crypto/chelsio/chcr_algo.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
> index 8952732c0b7d..c29b80dd30d8 100644
> --- a/drivers/crypto/chelsio/chcr_algo.c
> +++ b/drivers/crypto/chelsio/chcr_algo.c
> @@ -1437,7 +1437,6 @@ static int chcr_aes_decrypt(struct skcipher_request *req)
> static int chcr_device_init(struct chcr_context *ctx)
> {
> struct uld_ctx *u_ctx = NULL;
> - struct adapter *adap;
> int txq_perchan, ntxq;
> int err = 0, rxq_perchan;
>
> @@ -1448,7 +1447,6 @@ static int chcr_device_init(struct chcr_context *ctx)
> goto out;
> }
> ctx->dev = &u_ctx->dev;
> - adap = padap(ctx->dev);
> ntxq = u_ctx->lldi.ntxq;
> rxq_perchan = u_ctx->lldi.nrxq / u_ctx->lldi.nchan;
> txq_perchan = ntxq / u_ctx->lldi.nchan;
>
Thanks for fixing it. Looks good to me.
>
next prev parent reply other threads:[~2020-03-15 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 10:44 [PATCH -next] crypto: chelsio - remove set but not used variable 'adap' YueHaibing
2020-03-15 16:10 ` rohit maheshwari [this message]
2020-03-20 3:51 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcf6f896-8d60-836c-cdad-b5ca9c95b562@chelsio.com \
--to=rohitm@chelsio.com \
--cc=ayush.sawal@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=vinay.yadav@chelsio.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).