From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: Guo Ren <guoren@kernel.org>, Baruch Siach <baruch@tkos.co.il>,
Huacai Chen <chenhc@lemote.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Tony Lindgren <tony@atomide.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-csky@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mips@vger.kernel.org, linux-omap@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: [PATCH 3/7] irqchip/loongson-htvec: Check return value of irq_domain_translate_onecell()
Date: Tue, 23 Jun 2020 16:51:12 +0800 [thread overview]
Message-ID: <1592902276-3969-4-git-send-email-yangtiezhu@loongson.cn> (raw)
In-Reply-To: <1592902276-3969-1-git-send-email-yangtiezhu@loongson.cn>
Check the return value of irq_domain_translate_onecell() due to
it may returns -EINVAL if failed.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/irqchip/irq-loongson-htvec.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-loongson-htvec.c b/drivers/irqchip/irq-loongson-htvec.c
index b36d403..720cf96 100644
--- a/drivers/irqchip/irq-loongson-htvec.c
+++ b/drivers/irqchip/irq-loongson-htvec.c
@@ -109,11 +109,14 @@ static struct irq_chip htvec_irq_chip = {
static int htvec_domain_alloc(struct irq_domain *domain, unsigned int virq,
unsigned int nr_irqs, void *arg)
{
+ int ret;
unsigned long hwirq;
unsigned int type, i;
struct htvec *priv = domain->host_data;
- irq_domain_translate_onecell(domain, arg, &hwirq, &type);
+ ret = irq_domain_translate_onecell(domain, arg, &hwirq, &type);
+ if (ret)
+ return ret;
for (i = 0; i < nr_irqs; i++) {
irq_domain_set_info(domain, virq + i, hwirq + i, &htvec_irq_chip,
--
2.1.0
next prev parent reply other threads:[~2020-06-23 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 8:51 [PATCH 0/7] Fix potential resource leaks and do some code cleanups about irqchip Tiezhu Yang
2020-06-23 8:51 ` [PATCH 1/7] irqchip: Fix potential resource leaks Tiezhu Yang
2020-06-24 9:15 ` Krzysztof Kozlowski
2020-06-24 9:24 ` Tiezhu Yang
2020-06-23 8:51 ` [PATCH 2/7] irqchip/loongson-htpic: Remove redundant kfree operation Tiezhu Yang
2020-06-23 8:51 ` Tiezhu Yang [this message]
2020-06-23 8:51 ` [PATCH 4/7] irqchip/loongson-pch-pic: Check return value of irq_domain_translate_twocell() Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1592902276-3969-4-git-send-email-yangtiezhu@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=aou@eecs.berkeley.edu \
--cc=baruch@tkos.co.il \
--cc=chenhc@lemote.com \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=jason@lakedaemon.net \
--cc=jiaxun.yang@flygoat.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=maz@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).