From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3889BC04AB3 for ; Wed, 29 May 2019 07:21:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17CA321019 for ; Wed, 29 May 2019 07:21:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726104AbfE2HVe (ORCPT ); Wed, 29 May 2019 03:21:34 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:48185 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726604AbfE2HVd (ORCPT ); Wed, 29 May 2019 03:21:33 -0400 X-Originating-IP: 90.88.147.134 Received: from windsurf.home (aaubervilliers-681-1-27-134.w90-88.abo.wanadoo.fr [90.88.147.134]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id C30E44000B; Wed, 29 May 2019 07:21:29 +0000 (UTC) Date: Wed, 29 May 2019 09:21:28 +0200 From: Thomas Petazzoni To: guoren@kernel.org Cc: Thomas De Schampheleire , arnout@mind.be, linux-csky@vger.kernel.org, buildroot@buildroot.org, Guo Ren Subject: Re: [PATCH V3 01/10] arch/csky: Use VDSP instead of DSP Message-ID: <20190529092128.36183371@windsurf.home> In-Reply-To: <1559114328-23357-2-git-send-email-guoren@kernel.org> References: <1559114328-23357-1-git-send-email-guoren@kernel.org> <1559114328-23357-2-git-send-email-guoren@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-csky-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org Hello Guo, Thanks for this new iteration. I apologize, but unfortunately it's still not good, and doesn't match the suggestions I did. On Wed, 29 May 2019 15:18:39 +0800 guoren@kernel.org wrote: > From: Guo Ren > > Use VDSP enhanced instructions Co-processor instead of DSP. Your commit log should explain why. > Signed-off-by: Guo Ren > --- > arch/Config.in.csky | 17 +++-------------- > arch/arch.mk.csky | 24 ++++++++++++++++++++++++ The change to using arch.mk.csky should be done separately. So this commit should be split into two: - One switching to using arch.mk.sky, without changing DSP -> VDSP - A follow-up one changing DSP -> VDSP, with a commit log that explains why you make this chang Thanks, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com