Re: [Buildroot] [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: guoren@kernel.org
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
	arnout@mind.be, Guo Ren <ren_guo@c-sky.com>,
	zhiwei_liu@c-sky.com, linux-csky@vger.kernel.org,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig
Date: Sun, 2 Jun 2019 12:32:18 +0200	[thread overview]
Message-ID: <20190602123218.244963b8@windsurf> (raw)
In-Reply-To: <1559468510-22085-1-git-send-email-guoren@kernel.org>

Hello Guo,

On Sun,  2 Jun 2019 17:41:49 +0800
guoren@kernel.org wrote:

> From: Guo Ren <ren_guo@c-sky.com>
> 
> Add C-SKY defconfig for QEMU virt machine.
> 
> Tested with https://gitlab.com/c-sky/buildroot/pipelines
> 
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks, it looks a lot better, but there are still a few things to
improve.

First, the readme.txt file should be in the same patch.

Second, you should update the DEVELOPES file so that it covers those
additional files (board/qemu/csky and configs/qemu_csky*).

See below for other comments.

> diff --git a/board/qemu/csky/linux-ck610.config.fragment b/board/qemu/csky/linux-ck610.config.fragment
> new file mode 100644
> index 0000000..d80d0ee
> --- /dev/null
> +++ b/board/qemu/csky/linux-ck610.config.fragment
> @@ -0,0 +1,5 @@
> +CONFIG_COMPILE_TEST=y
> +CONFIG_CPU_CK610=y
> +CONFIG_CPU_PM_WAIT=y
> +CONFIG_CSKY_APB_INTC=y
> +CONFIG_GX6605S_TIMER=y

Thanks, this is _much_ better!

> diff --git a/configs/qemu_csky610_virt_defconfig b/configs/qemu_csky610_virt_defconfig
> new file mode 100644
> index 0000000..9a82d57
> --- /dev/null
> +++ b/configs/qemu_csky610_virt_defconfig
> @@ -0,0 +1,20 @@
> +# Architecture
> +BR2_csky=y
> +BR2_ck610=y

You need to add an option like this:

# Linux headers same as kernel, a 5.0 series
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_0=y

> +# System
> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y

Please don't enable mdev.

> +BR2_TARGET_ROOTFS_INITRAMFS=y
> +
> +# Toolchain
> +BR2_OPTIMIZE_2=y
> +BR2_SHARED_STATIC_LIBS=y
> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
> +BR2_PACKAGE_HOST_GDB=y

Please remove those options.

> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0.12"
> +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/csky/linux-ck610.config.fragment"

And of course, it should be changed similarly in all other defconfigs.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com