Linux-csky Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig
@ 2019-06-02  9:41 guoren
  2019-06-02  9:41 ` [PATCH V5 2/2] board/qemu/csky/readme.txt: Add C-SKY Qemu run Documentation guoren
  2019-06-02 10:32 ` [Buildroot] [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig Thomas Petazzoni
  0 siblings, 2 replies; 8+ messages in thread
From: guoren @ 2019-06-02  9:41 UTC (permalink / raw)
  To: Thomas Petazzoni, Thomas De Schampheleire, arnout
  Cc: linux-csky, buildroot, zhiwei_liu, Guo Ren

From: Guo Ren <ren_guo@c-sky.com>

Add C-SKY defconfig for QEMU virt machine.

Tested with https://gitlab.com/c-sky/buildroot/pipelines

Signed-off-by: Guo Ren <ren_guo@c-sky.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 .gitlab-ci.yml                              |  4 ++++
 board/qemu/csky/linux-ck610.config.fragment |  5 +++++
 board/qemu/csky/linux-ck807.config.fragment |  5 +++++
 board/qemu/csky/linux-ck810.config.fragment |  5 +++++
 board/qemu/csky/linux-ck860.config.fragment |  9 +++++++++
 configs/qemu_csky610_virt_defconfig         | 20 ++++++++++++++++++++
 configs/qemu_csky807_virt_defconfig         | 21 +++++++++++++++++++++
 configs/qemu_csky810_virt_defconfig         | 21 +++++++++++++++++++++
 configs/qemu_csky860_virt_defconfig         | 21 +++++++++++++++++++++
 9 files changed, 111 insertions(+)
 create mode 100644 board/qemu/csky/linux-ck610.config.fragment
 create mode 100644 board/qemu/csky/linux-ck807.config.fragment
 create mode 100644 board/qemu/csky/linux-ck810.config.fragment
 create mode 100644 board/qemu/csky/linux-ck860.config.fragment
 create mode 100644 configs/qemu_csky610_virt_defconfig
 create mode 100644 configs/qemu_csky807_virt_defconfig
 create mode 100644 configs/qemu_csky810_virt_defconfig
 create mode 100644 configs/qemu_csky860_virt_defconfig

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 374dbfe..4fa3473 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -248,6 +248,10 @@ qemu_aarch64_virt_defconfig: { extends: .defconfig }
 qemu_arm_versatile_defconfig: { extends: .defconfig }
 qemu_arm_versatile_nommu_defconfig: { extends: .defconfig }
 qemu_arm_vexpress_defconfig: { extends: .defconfig }
+qemu_csky610_virt_defconfig: { extends: .defconfig }
+qemu_csky807_virt_defconfig: { extends: .defconfig }
+qemu_csky810_virt_defconfig: { extends: .defconfig }
+qemu_csky860_virt_defconfig: { extends: .defconfig }
 qemu_m68k_mcf5208_defconfig: { extends: .defconfig }
 qemu_m68k_q800_defconfig: { extends: .defconfig }
 qemu_microblazebe_mmu_defconfig: { extends: .defconfig }
diff --git a/board/qemu/csky/linux-ck610.config.fragment b/board/qemu/csky/linux-ck610.config.fragment
new file mode 100644
index 0000000..d80d0ee
--- /dev/null
+++ b/board/qemu/csky/linux-ck610.config.fragment
@@ -0,0 +1,5 @@
+CONFIG_COMPILE_TEST=y
+CONFIG_CPU_CK610=y
+CONFIG_CPU_PM_WAIT=y
+CONFIG_CSKY_APB_INTC=y
+CONFIG_GX6605S_TIMER=y
diff --git a/board/qemu/csky/linux-ck807.config.fragment b/board/qemu/csky/linux-ck807.config.fragment
new file mode 100644
index 0000000..b6974f0
--- /dev/null
+++ b/board/qemu/csky/linux-ck807.config.fragment
@@ -0,0 +1,5 @@
+CONFIG_COMPILE_TEST=y
+CONFIG_CPU_CK807=y
+# CONFIG_CPU_HAS_FPU is not set
+CONFIG_CPU_PM_WAIT=y
+CONFIG_CSKY_APB_INTC=y
diff --git a/board/qemu/csky/linux-ck810.config.fragment b/board/qemu/csky/linux-ck810.config.fragment
new file mode 100644
index 0000000..50fa1f4
--- /dev/null
+++ b/board/qemu/csky/linux-ck810.config.fragment
@@ -0,0 +1,5 @@
+CONFIG_COMPILE_TEST=y
+CONFIG_CPU_CK810=y
+# CONFIG_CPU_HAS_FPU is not set
+CONFIG_CPU_PM_WAIT=y
+CONFIG_CSKY_APB_INTC=y
diff --git a/board/qemu/csky/linux-ck860.config.fragment b/board/qemu/csky/linux-ck860.config.fragment
new file mode 100644
index 0000000..e8f6af1
--- /dev/null
+++ b/board/qemu/csky/linux-ck860.config.fragment
@@ -0,0 +1,9 @@
+CONFIG_COMPILE_TEST=y
+CONFIG_CPU_CK860=y
+# CONFIG_CPU_HAS_FPU is not set
+CONFIG_CPU_PM_WAIT=y
+CONFIG_SMP=y
+CONFIG_HOTPLUG_CPU=y
+CONFIG_CSKY_APB_INTC=y
+CONFIG_CSKY_MPINTC=y
+CONFIG_CSKY_MP_TIMER=y
diff --git a/configs/qemu_csky610_virt_defconfig b/configs/qemu_csky610_virt_defconfig
new file mode 100644
index 0000000..9a82d57
--- /dev/null
+++ b/configs/qemu_csky610_virt_defconfig
@@ -0,0 +1,20 @@
+# Architecture
+BR2_csky=y
+BR2_ck610=y
+
+# System
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_TARGET_ROOTFS_INITRAMFS=y
+
+# Toolchain
+BR2_OPTIMIZE_2=y
+BR2_SHARED_STATIC_LIBS=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_PACKAGE_HOST_GDB=y
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0.12"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/csky/linux-ck610.config.fragment"
diff --git a/configs/qemu_csky807_virt_defconfig b/configs/qemu_csky807_virt_defconfig
new file mode 100644
index 0000000..8fe32e8
--- /dev/null
+++ b/configs/qemu_csky807_virt_defconfig
@@ -0,0 +1,21 @@
+# Architecture
+BR2_csky=y
+BR2_ck807=y
+
+# System
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_TARGET_ROOTFS_INITRAMFS=y
+
+# Toolchain
+BR2_OPTIMIZE_2=y
+BR2_SHARED_STATIC_LIBS=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_PACKAGE_HOST_GDB=y
+BR2_TARGET_OPTIMIZATION="-mbacktrace"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0.12"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/csky/linux-ck807.config.fragment"
diff --git a/configs/qemu_csky810_virt_defconfig b/configs/qemu_csky810_virt_defconfig
new file mode 100644
index 0000000..8fe3a0c
--- /dev/null
+++ b/configs/qemu_csky810_virt_defconfig
@@ -0,0 +1,21 @@
+# Architecture
+BR2_csky=y
+BR2_ck810=y
+
+# System
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_TARGET_ROOTFS_INITRAMFS=y
+
+# Toolchain
+BR2_OPTIMIZE_2=y
+BR2_SHARED_STATIC_LIBS=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_PACKAGE_HOST_GDB=y
+BR2_TARGET_OPTIMIZATION="-mbacktrace"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0.12"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/csky/linux-ck810.config.fragment"
diff --git a/configs/qemu_csky860_virt_defconfig b/configs/qemu_csky860_virt_defconfig
new file mode 100644
index 0000000..02408ad
--- /dev/null
+++ b/configs/qemu_csky860_virt_defconfig
@@ -0,0 +1,21 @@
+# Architecture
+BR2_csky=y
+BR2_ck860=y
+
+# System
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_TARGET_ROOTFS_INITRAMFS=y
+
+# Toolchain
+BR2_OPTIMIZE_2=y
+BR2_SHARED_STATIC_LIBS=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_PACKAGE_HOST_GDB=y
+BR2_TARGET_OPTIMIZATION="-mbacktrace"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0.12"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/csky/linux-ck860.config.fragment"
-- 
2.7.4


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH V5 2/2] board/qemu/csky/readme.txt: Add C-SKY Qemu run Documentation
  2019-06-02  9:41 [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig guoren
@ 2019-06-02  9:41 ` guoren
  2019-06-02 11:46   ` [Buildroot] " Thomas Petazzoni
  2019-06-02 10:32 ` [Buildroot] [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig Thomas Petazzoni
  1 sibling, 1 reply; 8+ messages in thread
From: guoren @ 2019-06-02  9:41 UTC (permalink / raw)
  To: Thomas Petazzoni, Thomas De Schampheleire, arnout
  Cc: linux-csky, buildroot, zhiwei_liu, Guo Ren

From: Guo Ren <ren_guo@c-sky.com>

Signed-off-by: Guo Ren <ren_guo@c-sky.com>
Cc: Liu Zhiwei <zhiwei_liu@c-sky.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 board/qemu/csky/readme.txt | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 board/qemu/csky/readme.txt

diff --git a/board/qemu/csky/readme.txt b/board/qemu/csky/readme.txt
new file mode 100644
index 0000000..c36c755d
--- /dev/null
+++ b/board/qemu/csky/readme.txt
@@ -0,0 +1,16 @@
+Run with qemu:
+
+ wget https://gitlab.com/c-sky/buildroot/-/jobs/197192514/artifacts/raw/output/images/csky_toolchain_csky_860_fpga_4.9_glibc_br_defconfig_56683a5a67ecf1dd0e67b05b9541de74530d0047.tar.xz;
+ mkdir tools;
+ tar -Jxf csky_toolchain_csky_860_fpga_4.9_glibc_br_defconfig_56683a5a67ecf1dd0e67b05b9541de74530d0047.tar.xz -C tools;
+ LD_LIBRARY_PATH=./tools/lib ./tools/csky-qemu/bin/qemu-system-cskyv2 -M virt -cpu ck860 -smp 2 -kernel output/images/vmlinux -nographic;
+
+For ck810/ck807:
+ LD_LIBRARY_PATH=./tools/lib ./tools/csky-qemu/bin/qemu-system-cskyv2 -M virt -kernel output/images/vmlinux -nographic;
+
+For ck610:
+ LD_LIBRARY_PATH=./tools/lib ./tools/csky-qemu/bin/qemu-system-cskyv1 -M virt -kernel output/images/vmlinux -nographic;
+
+The login prompt will appear in the terminal that started Qemu. Username is root and no password.
+
+Tested with QEMU 3.0 in https://gitlab.com/guoren83/qemu, C-SKY qemu upstream is on its way.
-- 
2.7.4


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig
  2019-06-02  9:41 [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig guoren
  2019-06-02  9:41 ` [PATCH V5 2/2] board/qemu/csky/readme.txt: Add C-SKY Qemu run Documentation guoren
@ 2019-06-02 10:32 ` Thomas Petazzoni
  2019-06-03  7:00   ` Guo Ren
  1 sibling, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2019-06-02 10:32 UTC (permalink / raw)
  To: guoren
  Cc: Thomas De Schampheleire, arnout, Guo Ren, zhiwei_liu, linux-csky,
	buildroot

Hello Guo,

On Sun,  2 Jun 2019 17:41:49 +0800
guoren@kernel.org wrote:

> From: Guo Ren <ren_guo@c-sky.com>
> 
> Add C-SKY defconfig for QEMU virt machine.
> 
> Tested with https://gitlab.com/c-sky/buildroot/pipelines
> 
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks, it looks a lot better, but there are still a few things to
improve.

First, the readme.txt file should be in the same patch.

Second, you should update the DEVELOPES file so that it covers those
additional files (board/qemu/csky and configs/qemu_csky*).

See below for other comments.


> diff --git a/board/qemu/csky/linux-ck610.config.fragment b/board/qemu/csky/linux-ck610.config.fragment
> new file mode 100644
> index 0000000..d80d0ee
> --- /dev/null
> +++ b/board/qemu/csky/linux-ck610.config.fragment
> @@ -0,0 +1,5 @@
> +CONFIG_COMPILE_TEST=y
> +CONFIG_CPU_CK610=y
> +CONFIG_CPU_PM_WAIT=y
> +CONFIG_CSKY_APB_INTC=y
> +CONFIG_GX6605S_TIMER=y

Thanks, this is _much_ better!

> diff --git a/configs/qemu_csky610_virt_defconfig b/configs/qemu_csky610_virt_defconfig
> new file mode 100644
> index 0000000..9a82d57
> --- /dev/null
> +++ b/configs/qemu_csky610_virt_defconfig
> @@ -0,0 +1,20 @@
> +# Architecture
> +BR2_csky=y
> +BR2_ck610=y

You need to add an option like this:

# Linux headers same as kernel, a 5.0 series
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_0=y

> +# System
> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y

Please don't enable mdev.

> +BR2_TARGET_ROOTFS_INITRAMFS=y
> +
> +# Toolchain
> +BR2_OPTIMIZE_2=y
> +BR2_SHARED_STATIC_LIBS=y
> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
> +BR2_PACKAGE_HOST_GDB=y

Please remove those options.

> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0.12"
> +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/csky/linux-ck610.config.fragment"

And of course, it should be changed similarly in all other defconfigs.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH V5 2/2] board/qemu/csky/readme.txt: Add C-SKY Qemu run Documentation
  2019-06-02  9:41 ` [PATCH V5 2/2] board/qemu/csky/readme.txt: Add C-SKY Qemu run Documentation guoren
@ 2019-06-02 11:46   ` " Thomas Petazzoni
  2019-06-03  6:47     ` Guo Ren
  0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2019-06-02 11:46 UTC (permalink / raw)
  To: guoren
  Cc: Thomas De Schampheleire, arnout, Guo Ren, zhiwei_liu, linux-csky,
	buildroot

Hello Guo,

On Sun,  2 Jun 2019 17:41:50 +0800
guoren@kernel.org wrote:

> + wget https://gitlab.com/c-sky/buildroot/-/jobs/197192514/artifacts/raw/output/images/csky_toolchain_csky_860_fpga_4.9_glibc_br_defconfig_56683a5a67ecf1dd0e67b05b9541de74530d0047.tar.xz;
> + mkdir tools;
> + tar -Jxf csky_toolchain_csky_860_fpga_4.9_glibc_br_defconfig_56683a5a67ecf1dd0e67b05b9541de74530d0047.tar.xz -C tools;
> + LD_LIBRARY_PATH=./tools/lib ./tools/csky-qemu/bin/qemu-system-cskyv2 -M virt -cpu ck860 -smp 2 -kernel output/images/vmlinux -nographic;
> +
> +For ck810/ck807:
> + LD_LIBRARY_PATH=./tools/lib ./tools/csky-qemu/bin/qemu-system-cskyv2 -M virt -kernel output/images/vmlinux -nographic;
> +
> +For ck610:
> + LD_LIBRARY_PATH=./tools/lib ./tools/csky-qemu/bin/qemu-system-cskyv1 -M virt -kernel output/images/vmlinux -nographic;

Instead of this, I think it makes sense to add support for C-SKY in the
host-qemu package. It should be fairly easy to do, and then you can
enable building host-qemu as part of the c-sky qemu defconfigs.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH V5 2/2] board/qemu/csky/readme.txt: Add C-SKY Qemu run Documentation
  2019-06-02 11:46   ` [Buildroot] " Thomas Petazzoni
@ 2019-06-03  6:47     ` Guo Ren
  2019-06-03  7:32       ` Thomas Petazzoni
  0 siblings, 1 reply; 8+ messages in thread
From: Guo Ren @ 2019-06-03  6:47 UTC (permalink / raw)
  To: Thomas Petazzoni
  Cc: Thomas De Schampheleire, arnout, Guo Ren, zhiwei_liu, linux-csky,
	buildroot

Hello Thomas,

On Sun, Jun 2, 2019 at 7:46 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Guo,
>
> On Sun,  2 Jun 2019 17:41:50 +0800
> guoren@kernel.org wrote:
>
> > + wget https://gitlab.com/c-sky/buildroot/-/jobs/197192514/artifacts/raw/output/images/csky_toolchain_csky_860_fpga_4.9_glibc_br_defconfig_56683a5a67ecf1dd0e67b05b9541de74530d0047.tar.xz;
> > + mkdir tools;
> > + tar -Jxf csky_toolchain_csky_860_fpga_4.9_glibc_br_defconfig_56683a5a67ecf1dd0e67b05b9541de74530d0047.tar.xz -C tools;
> > + LD_LIBRARY_PATH=./tools/lib ./tools/csky-qemu/bin/qemu-system-cskyv2 -M virt -cpu ck860 -smp 2 -kernel output/images/vmlinux -nographic;
> > +
> > +For ck810/ck807:
> > + LD_LIBRARY_PATH=./tools/lib ./tools/csky-qemu/bin/qemu-system-cskyv2 -M virt -kernel output/images/vmlinux -nographic;
> > +
> > +For ck610:
> > + LD_LIBRARY_PATH=./tools/lib ./tools/csky-qemu/bin/qemu-system-cskyv1 -M virt -kernel output/images/vmlinux -nographic;
>
> Instead of this, I think it makes sense to add support for C-SKY in the
> host-qemu package. It should be fairly easy to do, and then you can
> enable building host-qemu as part of the c-sky qemu defconfigs.
Qemu upstream is under way and I want to add host-qemu for C-SKY after that.

See here:
https://gitlab.com/c-sky/buildroot/tree/master/package/csky-qemu
I don't use package/qemu to build csky qemu and I add another
csky-qemu package for simple.

Best Regards
 Guo Ren

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig
  2019-06-02 10:32 ` [Buildroot] [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig Thomas Petazzoni
@ 2019-06-03  7:00   ` Guo Ren
  2019-06-03  7:30     ` Thomas Petazzoni
  0 siblings, 1 reply; 8+ messages in thread
From: Guo Ren @ 2019-06-03  7:00 UTC (permalink / raw)
  To: Thomas Petazzoni
  Cc: Thomas De Schampheleire, arnout, Guo Ren, zhiwei_liu, linux-csky,
	buildroot

Hello Thomas,

On Sun, Jun 2, 2019 at 6:32 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
> > From: Guo Ren <ren_guo@c-sky.com>
> >
> > Add C-SKY defconfig for QEMU virt machine.
> >
> > Tested with https://gitlab.com/c-sky/buildroot/pipelines
> >
> > Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> Thanks, it looks a lot better, but there are still a few things to
> improve.
>
> First, the readme.txt file should be in the same patch.
Ok.

>
> Second, you should update the DEVELOPES file so that it covers those
> additional files (board/qemu/csky and configs/qemu_csky*).
Ok, it'll be another patch.

>
> See below for other comments.
>
>
> > diff --git a/board/qemu/csky/linux-ck610.config.fragment b/board/qemu/csky/linux-ck610.config.fragment
> > new file mode 100644
> > index 0000000..d80d0ee
> > --- /dev/null
> > +++ b/board/qemu/csky/linux-ck610.config.fragment
> > @@ -0,0 +1,5 @@
> > +CONFIG_COMPILE_TEST=y
> > +CONFIG_CPU_CK610=y
> > +CONFIG_CPU_PM_WAIT=y
> > +CONFIG_CSKY_APB_INTC=y
> > +CONFIG_GX6605S_TIMER=y
>
> Thanks, this is _much_ better!
>
> > diff --git a/configs/qemu_csky610_virt_defconfig b/configs/qemu_csky610_virt_defconfig
> > new file mode 100644
> > index 0000000..9a82d57
> > --- /dev/null
> > +++ b/configs/qemu_csky610_virt_defconfig
> > @@ -0,0 +1,20 @@
> > +# Architecture
> > +BR2_csky=y
> > +BR2_ck610=y
>
> You need to add an option like this:
>
> # Linux headers same as kernel, a 5.0 series
> BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_0=y
Ok.

>
> > +# System
> > +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
>
> Please don't enable mdev.
Ok, I'll use BR2_ROOTFS_DEVICE_CREATION_STATIC=y.

>
> > +BR2_TARGET_ROOTFS_INITRAMFS=y
> > +
> > +# Toolchain
> > +BR2_OPTIMIZE_2=y
> > +BR2_SHARED_STATIC_LIBS=y
> > +BR2_TOOLCHAIN_BUILDROOT_CXX=y
> > +BR2_PACKAGE_HOST_GDB=y
>
> Please remove those options.
OK.

>
> > +# Kernel
> > +BR2_LINUX_KERNEL=y
> > +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> > +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0.12"
> > +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> > +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/csky/linux-ck610.config.fragment"
>
> And of course, it should be changed similarly in all other defconfigs.
OK.

Best Regards
 Guo Ren

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig
  2019-06-03  7:00   ` Guo Ren
@ 2019-06-03  7:30     ` Thomas Petazzoni
  0 siblings, 0 replies; 8+ messages in thread
From: Thomas Petazzoni @ 2019-06-03  7:30 UTC (permalink / raw)
  To: Guo Ren
  Cc: Thomas De Schampheleire, arnout, Guo Ren, zhiwei_liu, linux-csky,
	buildroot

Hello Guo,

On Mon, 3 Jun 2019 15:00:12 +0800
Guo Ren <guoren@kernel.org> wrote:

> > Second, you should update the DEVELOPES file so that it covers those
> > additional files (board/qemu/csky and configs/qemu_csky*).  
> Ok, it'll be another patch.

No, it should be in the same patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH V5 2/2] board/qemu/csky/readme.txt: Add C-SKY Qemu run Documentation
  2019-06-03  6:47     ` Guo Ren
@ 2019-06-03  7:32       ` Thomas Petazzoni
  0 siblings, 0 replies; 8+ messages in thread
From: Thomas Petazzoni @ 2019-06-03  7:32 UTC (permalink / raw)
  To: Guo Ren
  Cc: Thomas De Schampheleire, arnout, Guo Ren, zhiwei_liu, linux-csky,
	buildroot

Hello,

On Mon, 3 Jun 2019 14:47:09 +0800
Guo Ren <guoren@kernel.org> wrote:

> Qemu upstream is under way and I want to add host-qemu for C-SKY after that.
> 
> See here:
> https://gitlab.com/c-sky/buildroot/tree/master/package/csky-qemu
> I don't use package/qemu to build csky qemu and I add another
> csky-qemu package for simple.

Well, why not simply adding C-SKY support to the existing
package/qemu ? It should be fairly easy, just change the
version/source/site, and that's it ? Since you're in the process of
upstreaming, I assume you're using a recent version of Qemu, so all the
logic in qemu.mk for upstream Qemu should apply to the C-SKY variant as
well.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-02  9:41 [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig guoren
2019-06-02  9:41 ` [PATCH V5 2/2] board/qemu/csky/readme.txt: Add C-SKY Qemu run Documentation guoren
2019-06-02 11:46   ` [Buildroot] " Thomas Petazzoni
2019-06-03  6:47     ` Guo Ren
2019-06-03  7:32       ` Thomas Petazzoni
2019-06-02 10:32 ` [Buildroot] [PATCH V5 1/2] configs/qemu_cskyXXX_virt: new defconfig Thomas Petazzoni
2019-06-03  7:00   ` Guo Ren
2019-06-03  7:30     ` Thomas Petazzoni

Linux-csky Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-csky/0 linux-csky/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-csky linux-csky/ https://lore.kernel.org/linux-csky \
		linux-csky@vger.kernel.org linux-csky@archiver.kernel.org
	public-inbox-index linux-csky


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-csky


AGPL code for this site: git clone https://public-inbox.org/ public-inbox